277607 - useless expression in nsUpdateService.js

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P5)

Description

[crisp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

On startup the nsUpdateService.js produces a lot of strict JavaScript warnings,
which can be easily prevented:

Warning: useless expression
Source File:
file:///D:/Program%20Files/Mozilla%20Firefox/components/nsUpdateService.js
Line: 82

  if (!className)
    className == "<global>";


Warning: useless expression
Source File:
file:///D:/Program%20Files/Mozilla%20Firefox/components/nsUpdateService.js
Line: 85

  if (!functionName) 
    functionName == "<anonymous>";


Warning: redeclaration of var sbs
Source File:
file:///D:/Program%20Files/Mozilla%20Firefox/components/nsUpdateService.js
Line: 202, Column: 12
Source Code:
        var sbs = Components.classes["@mozilla.org/intl/stringbundle;1"]


Warning: redeclaration of var bundle
Source File:
file:///D:/Program%20Files/Mozilla%20Firefox/components/nsUpdateService.js
Line: 204, Column: 12
Source Code:
        var bundle =
sbs.createBundle("chrome://mozapps/locale/update/update.properties");


Warning: redeclaration of var ps
Source File:
file:///D:/Program%20Files/Mozilla%20Firefox/components/nsUpdateService.js
Line: 209, Column: 12
Source Code:
        var ps = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]

Reproducible: Always

Steps to Reproduce:
1. Install Web Developer extention
2. Tick 'enable javascript strict warnings' in the option
3. close and restart firefox

Actual Results:  
abovementioned warnings in the javascript console

Expected Results:  
the code should be such that no warnings are generated

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The redeclarations aren't significant.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: (Av1) Patch [Checked in: Comment 3]

Comment 3

[Ian Neal]

Comment on attachment 171601 [details] [diff] [review]
(Av1) Patch
[Checked in: Comment 3]

Checking in nsUpdateService.js.in;
/cvsroot/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in,v  <-- 
nsUpdateService.js.in
new revision: 1.7; previous revision: 1.6
done

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 171601 [details] [diff] [review]
(Av1) Patch
[Checked in: Comment 3]

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

Welcomed on branch too !

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <nsUpdateService.js.in>

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

(In reply to comment #1)
> The redeclarations aren't significant.

Yet, no reason not to fix them: clears the console.

Could you (super-)review/check in this patch ? Thanks.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 177001 [details] [diff] [review]
(Bv1) <nsUpdateService.js.in>

no SR needed for toolkit, but this isn't the right fix.

If you want to fix the strict warnings, declare the vars, but don't do the
getService calls unless necessary.  They're not always needed, and in fact
they're usually not hit.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 171601 [details] [diff] [review]
(Av1) Patch
[Checked in: Comment 3]

1.0.1 is a security release and Firefox 1.0.1 has already shipped.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) <nsUpdateService.js.in>

Bv1, with comment 6 suggestion(s),
plus getting rid of some variables.

Could you review/check in this patch ? Thanks.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 171601 [details] [diff] [review]
(Av1) Patch
[Checked in: Comment 3]

Please stop harassing drivers with approval requests for bugs without clear
explanations of why they are important to fix on the branch.  The point of
branches is that we *don't* take all changes on them.  We want to take only the
important ones, so that we have less chance of having regressions.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 177039 [details] [diff] [review]
(Bv2) <nsUpdateService.js.in>

No need to remove the redeclarations, and this is bitrotten.