277621 - Uninitialized value message when changing timetracking fields

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Max Kanat-Alexander]

If I put "12.12" in the "Estimated Hours" field when "Orig. Est" is "231.22," I
get three of these messages in my Apache error_log on landfill:

[Sat Jan 08 21:03:52 2005] [error] [client 216.233.214.179] [Sat Jan  8 21:03:52
2005] process_bug.cgi: Use of uninitialized value in string ne at
/var/www/html/bugzilla-tip/process_bug.cgi line 97., referer:
http://landfill.bugzilla.org/bugzilla-tip/post_bug.cgi

It happens any time I change that field, as far as I can tell.

That line of code is:

# Validate all timetracking fields
foreach my $field ("estimated_time", "work_time", "remaining_time") {
    if (defined $::FORM{$field}) {
        my $er_time = trim($::FORM{$field});
        if ($er_time ne $::FORM{'dontchange'}) { <======== THIS ONE
            Bugzilla::Bug::ValidateTime($er_time, $field);
        }
    }
}

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 170836 [details] [diff] [review]
Patch

bah, the diff viewer won't show me context because this was made with plain old
diff instead of cvs diff.  ;)

Comment 3

[Shane H. W. Travis]

2.18
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205.2.12; previous revision: 1.205.2.11
done

Tip:
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.222; previous revision: 1.221
done