277670 - Download manager overwrites existing files of same name without asking for confirmation

Status: RESOLVED WORKSFORME

(SeaMonkey :: Download & File Handling, defect)

Description

[James Blanford]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041207
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041207

I first noticed this downloading bootable iso images, which tend to have similar
names like boot.iso.  The second boot.iso I downloaded overwrote the first.

Reproducible: Always

Steps to Reproduce:
1.  Find a file or image to download anywhere on computer or internet
2.  Create a file of same name in any directory
3.  Download file in step #1 to directory in step #2

Actual Results:  
Created file is overwritten by downloaded file.

Expected Results:  
Download manager should request confirmation before overwriting file and give me
a chance to change the name of at least one of the files.

This is similar to bug #271037, but more general.  It doesn't seem to matter
what kind of file is downloaded, how it's selected or how they come to have the
same name - a new file will always overwrite the old, without any confirmation
being requested.

I've never seen this in any previous Mozilla

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

are you using a gtk1 or gtk2 build?

Comment 2

[James Blanford]

gtk2

Comment 3

[Boris Zbarsky [:bzbarsky]]

I thought this got fixed in bug 264210?

Comment 4

[Philip K. Warren]

I cannot reproduce this in today's trunk build.

Comment 5

[James Blanford]

Actually, I think this was caused (or perhaps, exposed) by the fix for bug
264210.  Anyway, I don't have the problem with recent builds.

Sometime in the middle of January the new file picker started working.  Before
that it was so badly broken, I couldn't tell what it was supposed to be doing. 
That would have been the bug report to file, but I was stumped on the "expected
results" part.