277673 - treeUtils.js uses .id whereas some files that call it use .number

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Ian Neal]

treeUtils.js uses .id in its SortTree function:
http://lxr.mozilla.org/seamonkey/source/browser/components/cookieviewer/content/treeUtils.js#110
http://lxr.mozilla.org/seamonkey/source/browser/components/cookieviewer/content/treeUtils.js#127
whereas passwordManager.js and CookieViewer.js use .number:
http://lxr.mozilla.org/seamonkey/source/toolkit/components/passwordmgr/resources/content/passwordManager.js#147
http://lxr.mozilla.org/seamonkey/source/toolkit/components/passwordmgr/resources/content/passwordManager.js#333
http://lxr.mozilla.org/seamonkey/source/browser/components/cookieviewer/content/CookieViewer.js#110

Comment 1

[Ian Neal]

Attachment: Changes .number to .id in CookieViewer and passwordManager v0.1

Comment 2

[Ian Neal]

Hmmm, ok, passwordManager.js doesn't use treeUtils.js but has a copy of most of
its functions. So either:
a) forget the passwordManager.js part of patch v0.1
b) I'll generate a replacement patch which makes .number -> .id changes in
passwordManager.js's SortTree code
c) Another option for example:
Move treeUtils.js into perhaps toolkit/content and have passwordManager.js use
it and delete the extra code from passwordManager.js

Comment 3

[Ian Neal]

Looking deeper into things it looks like the fix to bug 215656 never made it to
passwordManager.js - is option c) worth looking at?

Comment 4

[Phil Ringnalda (:philor)]

Looks like the 2005-02 new prefwindow pretty well wiped the landscape clean for this bug: no .id, no .number, no treeUtils.js.