277787 - Altering certain styles of a designMode iframe causes designMode to die. [midas]

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[James Sleeman]

Sumamry says it all really, changing style.display or style.position of an
iframe with designMode on causes designMode to turn off. 

I'll attach a testcase which walks you through thw two main problems.

This is /almost/ able to be worked around (by turning it back on), but it means
that any selection in the designMode on iframe is lost (not the content of the
selection, just the selection (hilite) itself).  Unfortunatly I can't find a way
to grab selection, turn off designMode, do the style change, turn on designMode
and reselect the previously selected text.

Comment 1

[James Sleeman]

Attachment: Testcase

Comment 2

[José Jeria]

With trunk build 20050110 on Win XP, the designmode stays when clicking the
first button, but lost on the second (position:relative)

Comment 3

[Boris Zbarsky [:bzbarsky]]

The first button actually does absolutely nothing in a current build, since the
display is not changed when all is said and done.  That's why it doesn't cause
any problems.

For the rest, a frame reconstruct will destroy the presshell in the iframe.  It
sounds like Midas doesn't deal with that very well.

Note that selection will definitely get destroyed with the presshell, so that
will be a problem even if this bug is fixed....

Comment 4

[Martijn Wargers (dead)]

Attachment: Fixed testcase

Same testcase as before, but now both ways cause designMode not to work anymore
(as already described in this bug and testcase).

Comment 5

[Derek Davenport]

Also turns off when changing visibility.

Comment 6

[Johnny Stenback (:jst)]

This was fixed by bug 284245.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

https://bugzilla.mozilla.org/attachment.cgi?id=175929 is now working fine for me
using build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050628 on Windows XP Seamonkey trunk.

Verified FIXED

Comment 8

[Mathieu Jobin]

I'm using deerpark from July 12
and when I use a RichEdit I can only type if there is text already.
and I have to click on a line that has text. if there is no text, there is no
where to click.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Mathieu Jobin, that doesn't sound like it's related to this bug at all.  Please
file a new bug on that, ok?  One bug per issue.