277792 - --enable-reorder produces non-loadable mozilla-bin with gcc 2.953 in BeOS R5 due voluntary assumptions in mklinkscript.pl

Status: RESOLVED INCOMPLETE

(Firefox Build System :: General, defect)

Description

[Sergei Dolgov]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7a) Gecko/20050108
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.85a) Gecko/20050108

Mozilla or FireFox built under BeOS R5.0* (netserver) with gcc 2.95.3
(http://bebits.com/app/4011) cannot start.
Message in shell is "cannot execute binary".
Author of gcc 2.95.3 port for BeOS, Oliver Tappe, had look at that problem, and
found, that line 
print TMP "*(.text)\n";
in mozilla/config/mklinkscript.pl is too "brave" in assumptions.

Hope his comment and patch will follow.

Though, as notice. It seems that ELF loader (?) in later BeOS version can handle
such builds, but IMHO, it is better to have in future less voluntary and more
generic linkscript

Reproducible: Always

Steps to Reproduce:

Comment 1

[Sergei Dolgov]

Attachment: preliminary patch

Preliminary patch before Oliver's more robust comments

Comment 2

[Sergei Dolgov]

Oliver, when you reach this,
look at
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mklinkscript.pl
namely, at version 3.1 link.
Portion in discussion was created under rewite which allows statically linked
app, but bug number there seems wrong.

Comment 3

[Oliver Tappe]

I believe that mklinkscript.pl insists on the default linker script of (gnu) ld having a 
specific format which isn't the case with newer ld versions.
ld --verbose (with ld-2.10) produces these lines:
---
  .text      :
  {
    *(.text)
---
at the start of the text section and mklinkscript.pl expects to find them like this.

However (at least) ld-2.15 yields this instead:
---
  .text           :
  {
    *(.text .stub .text.* .gnu.linkonce.t.*)
---
which causes mklinkscript.pl to replace the last line by '*(.text)' resulting in the loss 
of .stub .text.* and .gnu.linkonce.t.* sections during the link with the generated linker 
script (and I suppose that especially dropping linkonce sections is no good).

The patch that Sergei has attached is my way of convincing mklinkscript.pl to *copy* the 
line following the '{' instead of blindly replacing it with '*(.text)' only.

Comment 4

[(not currently active) Ted Mielczarek]

This code doesn't exist any more on the trunk or 1.9.0 branches.