277842 - virtual folder does not populate if quicksearch selection doesn't match folder search category

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Asa Dotzler [:asa]]

virtual folder created from quicksearch on "entire message" fails to populate if
quicksearch is not set on "entire message" on IMAP account

steps to repro:
1. focus the quicksearch field, select "entire message", and and type in the
letter "a". 
2. if this gives results, then save that as a search folder. if no results, your
mailbox must be empty :-)
3. set quicksearch field to "subject or sender"
4. select the saved search folder and observe that you get no results.
5. switch the quicksearch to "entire message", select some other folder besides
the saved search folder, then select the saved search folder and you will see
results.

results: 
With something other than "entire message" selected in the quicksearch field,
you won't get any results in the saved search folder. 

additional info: this happens regardless of whether the saved search is set to
search online or not.
Tested on Thunderbird 1.0 with two different IMAP servers.

Comment 1

[Asa Dotzler [:asa]]

I've investigated this a bit further. If you create a virtual folder with rules
to search on the message body and rules to search on subject or sender, then you
only get results in the virtual folder for either the body or the
subject/sender, depending on the quick search criteria selected. 

This seems like a pretty major failing in virtual folders. Scott, can you take a
look at this? I've got a simple example I can show you on my machine. 

Comment 2

[Anders Betnér]

I've tested this on trunk 2005-06-27 and it shows the same error as described in
the first comment. I haven't tried it for pop accounts but it surely doesn't
work with imap.

Comment 3

[Scott MacGregor]

Interesting. I see this when I first create the virtual folder. but as soon as I
restart the application, it always works regardless of the value of the quick
search selection type.

Comment 4

[Scott MacGregor]

hmm, now I don't even have to restart. The first time I try to load the folder I
get 0 matches. But every other time we load it after that, it works. 

Comment 5

[Scott MacGregor]

asa pointed out another tip to make it easier to see this.

have a couple search terms in the VF which use different criteria.

Note that the virtual folder search only seems to work for the criteria that
happens to match what is selected in the quick search bar

Comment 6

[David :Bienvenu]

the fix for Bug 298285 may fix this.

Comment 7

[Scott MacGregor]

It doesn't look like Bug 298285 fixed this for us. 

On my test VF, when the quick search text is set to Subject or Sender, the
results are very fast. When it is sett to Entire Message body, the folder takes
a very long time to load. And the VF is not using any quick search terms so the
value of the menu list should not be effecting loading the VF. And the # of
results is different as well.

using an 8/15 build

Comment 8

[Scott MacGregor]

I think I found the problem.

http://lxr.mozilla.org/mozilla/source/mail/base/content/searchBar.js#393

We only set the search scope to search online for imap accounts if the quick
search mode == searchbody

We should also walk through the search terms we are going to add, checking the
search type of each one before deciding whether to search online or not.

Comment 9

[Scott MacGregor]

Attachment: possible fix

David, what do you think about this solution? Is just checking the body
attribute too specific? Should we be checking for other search attribute values
besides body when deciding to set the scope to online?

I thought it was easier to isolate all of this logic in its own method,
getScopeToUse.

Comment 10

[Scott MacGregor]

Attachment: updated fix

simplify the logic a bit based on some comments David made over IM

Comment 11

[Scott MacGregor]

fixed branch and trunk