Live resizing of sheets is broken as a result of the checkin for bug 223545 because InstallWindowEventHandler() is being called twice with the same event class in the sheet case. This is illegal, and the second call, which installs the resize handler among other things, fails. The following assertion is generated: ###!!! ASSERTION: Couldn't install Carbon window event handler: 'err == noErr', file nsMacWindow.cpp, line 570
Created attachment 170871 [details] [diff] [review] patch
Attachment #170871 - Flags: review?(sfraser_bugs)
Created attachment 172125 [details] [diff] [review] v1 If you do it that way, you'll need to dispose of the UPP. Here's an alternate patch that I had in my tree (forgot to file a bug on it).
Attachment #170871 - Flags: review?(sfraser_bugs) → review-
It's hard to see the real changes among the TARGET_CARBON cleanup. Any chance of two patches? BTW, it might be better just to do pre-TARGET_CARBON cleanup in one sweep throughout widget and gfx, maybe in a separate bug.
Created attachment 172199 [details] [diff] [review] v1 without cleanup
TARGET_CARBON cleanup is bug 279510.
Comment on attachment 172199 [details] [diff] [review] v1 without cleanup Splendid.
Attachment #172199 - Flags: superreview?(sfraser_bugs) → superreview+
Attachment #172199 - Flags: review?(jhpedemonte) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.