live sheet resizing is broken (regression from bug 223545)

VERIFIED FIXED

Status

Core Graveyard
Widget: Mac
VERIFIED FIXED
13 years ago
8 years ago

People

(Reporter: Ari, Assigned: peterv)

Tracking

Trunk
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
Live resizing of sheets is broken as a result of the checkin for bug 223545 because 
InstallWindowEventHandler() is being called twice with the same event class in the sheet case. This is 
illegal, and the second call, which installs the resize handler among other things, fails. The following 
assertion is generated:

###!!! ASSERTION: Couldn't install Carbon window event handler: 'err == noErr', file nsMacWindow.cpp, 
line 570
(Reporter)

Comment 1

13 years ago
Created attachment 170871 [details] [diff] [review]
patch
Attachment #170871 - Flags: review?(sfraser_bugs)
(Assignee)

Comment 2

13 years ago
Created attachment 172125 [details] [diff] [review]
v1

If you do it that way, you'll need to dispose of the UPP. Here's an alternate
patch that I had in my tree (forgot to file a bug on it).
(Assignee)

Updated

13 years ago
Assignee: sfraser_bugs → peterv
Attachment #170871 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #172125 - Flags: review?(jhpedemonte)
(Assignee)

Updated

13 years ago
Attachment #170871 - Flags: review?(sfraser_bugs) → review-

Comment 3

13 years ago
It's hard to see the real changes among the TARGET_CARBON cleanup. Any chance of
two patches?

BTW, it might be better just to do pre-TARGET_CARBON cleanup in one sweep
throughout widget and gfx, maybe in a separate bug.
(Assignee)

Comment 4

13 years ago
Created attachment 172199 [details] [diff] [review]
v1 without cleanup
Attachment #172125 - Attachment is obsolete: true
Attachment #172199 - Flags: superreview?(sfraser_bugs)
Attachment #172199 - Flags: review?(jhpedemonte)
(Assignee)

Updated

13 years ago
Attachment #172125 - Flags: review?(jhpedemonte)
(Assignee)

Comment 5

13 years ago
TARGET_CARBON cleanup is bug 279510.

Comment 6

13 years ago
Comment on attachment 172199 [details] [diff] [review]
v1 without cleanup

Splendid.
Attachment #172199 - Flags: superreview?(sfraser_bugs) → superreview+

Updated

13 years ago
Attachment #172199 - Flags: review?(jhpedemonte) → review+
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

8 years ago
Component: Widget: Mac → Widget: Mac
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.