Closed Bug 277845 Opened 20 years ago Closed 20 years ago

live sheet resizing is broken (regression from bug 223545)

Categories

(Core Graveyard :: Widget: Mac, defect)

Product:
Core Graveyard
Component:
Widget: Mac
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: the_great_spam_bin, Assigned: peterv)

Details

Attachments

(1 file, 2 obsolete files)

v1 without cleanup
4.29 KB, patch
jhpedemonte
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review 
Live resizing of sheets is broken as a result of the checkin for bug 223545 because 
InstallWindowEventHandler() is being called twice with the same event class in the sheet case. This is 
illegal, and the second call, which installs the resize handler among other things, fails. The following 
assertion is generated:

###!!! ASSERTION: Couldn't install Carbon window event handler: 'err == noErr', file nsMacWindow.cpp, 
line 570
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #170871 -
        Flags: review?(sfraser_bugs)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1 (obsolete)
        — 
          — Splinter Review
      

    


  
If you do it that way, you'll need to dispose of the UPP. Here's an alternate
patch that I had in my tree (forgot to file a bug on it).

    
  
Assignee: sfraser_bugs → peterv

        Attachment #170871 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #172125 -
        Flags: review?(jhpedemonte)

    
  

        Attachment #170871 -
        Flags: review?(sfraser_bugs) → review-

    
    

    
  
It's hard to see the real changes among the TARGET_CARBON cleanup. Any chance of
two patches?

BTW, it might be better just to do pre-TARGET_CARBON cleanup in one sweep
throughout widget and gfx, maybe in a separate bug.

    
    

    
  


  

        Attachment #172125 -
        Attachment is obsolete: true

        Attachment #172199 -
        Flags: superreview?(sfraser_bugs)

        Attachment #172199 -
        Flags: review?(jhpedemonte)

    
  

        Attachment #172125 -
        Flags: review?(jhpedemonte)

    
    

    
  
TARGET_CARBON cleanup is bug 279510.

    
    

    
  
Comment on attachment 172199 [details] [diff] [review]
v1 without cleanup

Splendid.

        Attachment #172199 -
        Flags: superreview?(sfraser_bugs) → superreview+

        Attachment #172199 -
        Flags: review?(jhpedemonte) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: