277848 - mozilla\xpfe\bootstrap\nsAppRunner.cpp(1629) : warning C4101: 'i' : unreferenced local variable

Status: RESOLVED WORKSFORME

(Core Graveyard :: GFX: Gtk, defect)

Description

[alanjstr]

mozilla\xpfe\bootstrap\nsAppRunner.cpp(1629) : warning C4101: 'i' : unreferenced
local variable

This error seems to be caused by bug 258055

Comment 1

[alanjstr]

Attachment: Patch to nsAppRunner.cpp

Only defines i when it is going to be used.

Comment 2

[[e-mail]]

MOZ_WIDGET_GTKn implies MOZ_X11, surely? So you can just move the decl.

Comment 3

[alanjstr]

I did this specifically for
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsAppRunner.cpp#1673

Comment 4

[Justin Wood (:Callek)]

from https://bugzilla.mozilla.org/attachment.cgi?id=170872

Looks good to me, the variable |i| is only used in those conditions.

if I could r+sr I would ;-)

re c#2 if that is a useful assumption (I'm not sure) then I wonder why #ifdef
MOZ_X11 is not just removed entirely (at the link from c#3) and instead the
MOZ_WIDGET_GTKn #if moved up to encapsulate that.

Comment 5

[timeless]

Comment on attachment 170872 [details] [diff] [review]
Patch to nsAppRunner.cpp

someone is building gtk(2?)embed on windows, and i'm 99% certain they aren't
building against x11. i'm not quite sure what that gtk code would do on
windows, perhaps the code should be ifdef MOZ_X11, we can file a bug against
widget:gtk asking about it.

Comment 6

[Mats Palmgren (inactive)]

xpfe/bootstrap/nsAppRunner.cpp have been removed.
The toolkit version does not have this problem AFAICT.
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/xre/nsAppRunner.cpp&rev=1.169&root=/cvsroot#2173

-> WORKSFORME