277929 - Error in XForms XPath parser

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

It aborts on this (valid) expression: "value[@no >= ../from and @no <=
../to]".

It's a problem in the parser, which triggers a call to the
XPathCompilerException-hack.

Comment 1

[Allan Beaufour]

Attachment: test case

Comment 2

[Allan Beaufour]

Maybe I should note that is in nsXFormsXPathParser, not the Transformiix code,
so the bug is all mine :)

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

it's too bad that xforms has to have its own xpath parser. What kind of
information do you guys need to get from a parsed xpath expression? Maybe
transformiix could expose some interface that let you get information out of a
parsed nsIDOMXPathExpression?

Comment 4

[Allan Beaufour]

(In reply to comment #3)
> it's too bad that xforms has to have its own xpath parser.

You are absolutely right! I just ported some existing code to get us started.

> What kind of information do you guys need to get from a parsed xpath
> expression? Maybe transformiix could expose some interface that let you get
> information out of a parsed nsIDOMXPathExpression?

That has been my idea all the time (see bug 265212). I've talked a bit with pike
and peterv about it, but none of us has gotten further than thinking I suppose.

Comment 5

[aaronr]

Attachment: simpler expression that also gives error

here is a testcase with a much simpler expression that also shows the bug

Comment 6

[Allan Beaufour]

Attachment: Fix

A misunderstanding of the semantics of EqualsASCII().

Comment 7

[Doron Rosenberg (IBM)]

Comment on attachment 175437 [details] [diff] [review]
Fix

r=me

Comment 8

[Allan Beaufour]

Chcked in.