278036 - nsXULTextField should have "activate" action

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

Steps to Reproduce:
1. Start GOK and launch Mozilla.
2. In GOK main window, click menus->Bookmark->Bookmark Manager.
3. In GOK main window, click UI Grab.

Bug Observation:
The "Search" item in the GOK UI-Grab should be active

XUL textfield has no action defined and GOK can't grab any element without action.

Comment 1

[Louie Zhao]

Attachment: patch v1

Comment 2

[Philip K. Warren]

Comment on attachment 170992 [details] [diff] [review]
patch v1

>Index: accessible/src/xul/nsXULFormControlAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/xul/nsXULFormControlAccessible.cpp,v
>retrieving revision 1.41
>diff -p -u -5 -r1.41 nsXULFormControlAccessible.cpp
>--- accessible/src/xul/nsXULFormControlAccessible.cpp	1 Jul 2004 20:43:03 -0000	1.41
>+++ accessible/src/xul/nsXULFormControlAccessible.cpp	12 Jan 2005 05:21:30 -0000
...
>+  return NS_OK;;

Remove the extra semicolon.

Everything else looks great.

Comment 3

[Philip K. Warren]

Louie - this patch should be ready to be checked in now.

Comment 4

[Louie Zhao]

Thanks for r & sr. Patch checked in.