278047 - mozilla does not switch profile completely to a different locale selection

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Boying Lu]

Steps to reproduce
1.Invoke mozilla browser $mozilla -selectprofile
2.Create an english profile and any other language profile (ex: spanish)
3.Log into english profile and "switch profile" to previously created spanish
profile

Observation and bug : when mozilla is reinvoked only the dialog boxes are in
spanish and main tool bar and drop down menus remain english. 

note : however quit browser, invoke mozilla again and create a spanish profile
with a different name and logon. The profile change of browser is complete
(toolbars and menus are in spanish). The user cannot switch to an english
profile unless one creates another english profile.

Comment 1

[Boying Lu]

Attachment: Force to flush xul cache when swithing profile

Comment 2

[Boying Lu]

Comment on attachment 171242 [details] [diff] [review]
Force to flush xul cache when swithing profile

Thanks for your comment in the newsgroup. Now I made a patch. Would you please
reivew it? Thanks

Comment 3

[[e-mail]]

Comment on attachment 171242 [details] [diff] [review]
Force to flush xul cache when swithing profile

The XUL cache should already be flushed by the chrome-flush-caches
notification. The trouble is, nobody calls it. Oops :-(

Comment 4

[[e-mail]]

Actually nsChromeRegistry::FlushAllCaches calls it, but only
nsChromeRegistry:ReloadChrome calls that.

bsmedberg, darin: who should be flushing the xul cache on profile switch?

Comment 5

[Boying Lu]

Attachment: forece chrome-flush-caches when switching profile

Comment 6

[Boying Lu]

Comment on attachment 171249 [details] [diff] [review]
forece chrome-flush-caches when switching profile

r?

Comment 7

[Benjamin Smedberg]

Comment on attachment 171249 [details] [diff] [review]
forece chrome-flush-caches when switching profile

This call should not be made by UI code. I believe that the best place for this
call would be at nsChromeRegistry::Observe (only the seamonkey version) for the
profile-before-change topic.

Comment 8

[Boying Lu]

I added a call FlushAllCaches() in nsChromeRegistry::Observe()
"profile-before-change" section, but it doesn't work. Actually, when I lauch
mozilla with a profile using Chinese, Menu labels are shown in English instead.

Comment 9

[Boying Lu]

Attachment: Flush caches in nsChromeRegistry::Observe() "profile-before-change" section

Sorry, I make a mistake in my worksapce. Now the patch works for me.

Comment 10

[Boying Lu]

Comment on attachment 171336 [details] [diff] [review]
Flush caches in nsChromeRegistry::Observe()  "profile-before-change" section

r now?

Comment 11

[Kyle Yuan]

Checking in nsChromeRegistry.cpp;
/cvsroot/mozilla/rdf/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.313; previous revision: 1.312
done