278105 - Crash using XPath extension function 'instance()'

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

The retrieved instance is nsnull, which is correct since the external instance
is nonexistant, but crashing might not be the correct way of handling it :)

Program ./mozilla-bin (pid = 30518) received signal 11.
Stack:
_ZN13nsProfileLock18FatalSignalHandlerEi+0x000000DE
[/store/mozilla/source/branch-xforms/dist/bin/components/libprofile.so +0x00025A22]
UNKNOWN [/lib/libpthread.so.0 +0x0000CE31]
UNKNOWN 0xffffe420
_ZN18XFormsFunctionCall8evaluateEP14txIEvalContextPP13txAExprResult+0x00000D91
[/store/mozilla/source/branch-xforms/dist/bin/components/libtransformiix.so
+0x0006FE19]
UNKNOWN
[/store/mozilla/source/branch-xforms/dist/bin/components/libtransformiix.so
+0x00066160]
UNKNOWN
[/store/mozilla/source/branch-xforms/dist/bin/components/libtransformiix.so
+0x0006B1DF]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libxforms.so
+0x00033210]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libxforms.so
+0x000339BA]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libxforms.so
+0x00042E9F]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libxforms.so
+0x00042D45]
_ZN19nsXTFElementWrapper7SetAttrEiP7nsIAtomS1_RK9nsAStringi+0x000000B4
[/store/mozilla/source/branch-xforms/dist/bin/components/libgklayout.so +0x0073A978]
_ZN16nsXMLContentSink13AddAttributesEPPKtP10nsIContent+0x000000FD
[/store/mozilla/source/branch-xforms/dist/bin/components/libgklayout.so +0x0061C1F3]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libgklayout.so
+0x0061A8E4]
_ZN13nsExpatDriver18HandleStartElementEPKtPS1_+0x000000C6
[/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so +0x000351E8]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x000344C7]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x0005F56B]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x0005EDC7]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x00061BDC]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x00061605]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x000612ED]
MOZ_XML_Parse+0x00000118
[/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so +0x0005E877]
_ZN13nsExpatDriver11ParseBufferEPKcji+0x0000007A
[/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so +0x000365A2]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x00036870]
_ZN8nsParser8TokenizeEi+0x0000010B
[/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so +0x0004FDF5]
_ZN8nsParser11ResumeParseEiii+0x00000111
[/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so +0x0004E6AF]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libhtmlpars.so
+0x0004FB05]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libdocshell.so
+0x00084548]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libnecko.so
+0x000A9009]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libnecko.so
+0x00125918]
_ZN17nsInputStreamPump15OnStateTransferEv+0x00000239
[/store/mozilla/source/branch-xforms/dist/bin/components/libnecko.so +0x00086A8D]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libnecko.so
+0x000866F5]
_ZN23nsInputStreamReadyEvent12EventHandlerEP7PLEvent+0x0000005D
[./libxpcom_core.so +0x000B98D7]
PL_HandleEvent+0x00000045 [./libxpcom_core.so +0x000D6A21]
PL_ProcessPendingEvents+0x000000B6 [./libxpcom_core.so +0x000D68FA]
UNKNOWN [./libxpcom_core.so +0x000D943E]
UNKNOWN
[/store/mozilla/source/branch-xforms/dist/bin/components/libwidget_gtk2.so
+0x0002F37E]
UNKNOWN [/opt/gnome/lib/libglib-2.0.so.0 +0x0004B08F]
g_main_context_dispatch+0x000001D7 [/opt/gnome/lib/libglib-2.0.so.0 +0x000240B7]
UNKNOWN [/opt/gnome/lib/libglib-2.0.so.0 +0x000267F7]
g_main_loop_run+0x00000207 [/opt/gnome/lib/libglib-2.0.so.0 +0x000279E7]
gtk_main+0x000000B3 [/opt/gnome/lib/libgtk-x11-2.0.so.0 +0x00111833]
UNKNOWN
[/store/mozilla/source/branch-xforms/dist/bin/components/libwidget_gtk2.so
+0x0002F928]
UNKNOWN [/store/mozilla/source/branch-xforms/dist/bin/components/libappcomps.so
+0x000C6E35]
UNKNOWN [./mozilla-bin +0x00008DB2]
UNKNOWN [./mozilla-bin +0x00009762]
__libc_start_main+0x000000BB [/lib/libc.so.6 +0x0001592B]

Comment 1

[Allan Beaufour]

Attachment: Test case

Comment 2

[aaronr]

Attachment: fix for bug

didn't check for possibility that there would be an instance element but no
root to the data.  Fixed now.

Comment 3

[Darin Fisher]

Comment on attachment 171090 [details] [diff] [review]
fix for bug

eventually, it might be nice to report errors in the JS console.

sr=darin

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 171090 [details] [diff] [review]
fix for bug

mkaply was seeing this because we don't do relative urls on file://, right?

Comment 5

[Darin Fisher]

Hmm... well, the file: protocol does support relative URLs, so that wouldn't
explain it.  When I applied Aaron's patch, the testcase just worked.

Comment 6

[aaronr]

Doron was kind enough to check into branch for me.

Comment 7

[aaronr]

I moved this fix into my xpath patch (bug 258472) since this bug needed that
patch in to show up anyhow.  So once that goes in, this bug can be closed.

Comment 8

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

bug 258472 has been fixed so closing this one.