278113 - Handling 'out' params incorrectly

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[jhp (no longer active)]

Created a testcase that calls a function with an 'out' param which crashes in
nsJavaWrapper.  The problem is that in SetupParams, I use aVariant.ptr, but in
FinalizeParams, I reference aVariant.val.p.  Need to be consistent.

Comment 1

[jhp (no longer active)]

Attachment: patch

Turns out there were many problems with parameter handling, in addition to the
inconsistency mentioned above:
- Shouldn't hold Java array and string contents across invocations.  For
example, calling GetIntArrayElements() in SetupParams(), then invoking the
function, and finally calling ReleaseIntArrayElements() in FinalizeParams() is
wrong.	This pins the memory of that array in the JVM and doesn't allow it to
me moved or garbage collected, if necessary.  This patch uses more efficient
functions and does not hold any JVM memory across function invocations.
- Currently doesn't take into account that the caller can pass in null for
'inout', 'out', and 'retval' params.  This fixes that.
- Patch also makes similar changes in nsJavaXPTCStub.
- Always need to call ReleaseStringChars/ReleaseArrayElements, no matter if
isCopy is TRUE or FALSE.

Comment 2

[jhp (no longer active)]

Attachment: patch (diff -w)

Comment 3

[Darin Fisher]

Comment on attachment 171049 [details] [diff] [review]
patch (diff -w)

r=darin

Comment 4

[jhp (no longer active)]

Checked in to trunk.  -> FIXED