278134 - Bookmarks toolbar folder created twice after import

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Geert Poels]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

An empty bookmarks file only features the folder 'Bookmarks toolbar folder'
This folder is not deletable.
After an import of previous exported bookmarks (where this folder is already
included), the 'Bookmarks toolbar folder' appears twice.
The first folder remains empty.
The new folder, with the same name, has the bookmarks.
They should have merged both.
The bookmarks present in the exported version appear in the second folder.
I suppose they are not taken into account because no bookmark appears on the
bookmarks toolbar of my browser.

Reproducible: Always

Steps to Reproduce:
1. Add some bookmarks, both in the normal folder and the 'Bookmarks toolbar folder'.
2. Export these.
3. Delete all bookmarks (notice how the 'Bookmarks toolbar folder' can be erased)
4. Import your exported bookmarks again
5. Notice how you have two 'Bookmarks toolbar folder's.
   You'll have no visible bookmarks in your browser's bookmarks toolbar because
they are all in the second folder.


Expected Results:  
The links from the two 'Bookmarks toolbar folder' should have merged.

Comment 1

[morales78705]

My friend and I are also experiencing this. I'm on Mozilla/5.0 (Windows; U;
Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511.

However, the folder in question is named "Personal Toolbar Folder"; nonetheless,
the problem remains the same: after exporting bookmarks, clearing them out, and
re-importing them a duplicate "Personal Toolbar Folder" is created.

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
> 
> An empty bookmarks file only features the folder 'Bookmarks toolbar folder'
> This folder is not deletable.
> After an import of previous exported bookmarks (where this folder is already
> included), the 'Bookmarks toolbar folder' appears twice.
> The first folder remains empty.
> The new folder, with the same name, has the bookmarks.
> They should have merged both.
> The bookmarks present in the exported version appear in the second folder.
> I suppose they are not taken into account because no bookmark appears on the
> bookmarks toolbar of my browser.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Add some bookmarks, both in the normal folder and the 'Bookmarks toolbar
folder'.
> 2. Export these.
> 3. Delete all bookmarks (notice how the 'Bookmarks toolbar folder' can be erased)
> 4. Import your exported bookmarks again
> 5. Notice how you have two 'Bookmarks toolbar folder's.
>    You'll have no visible bookmarks in your browser's bookmarks toolbar because
> they are all in the second folder.
> 
> 
> Expected Results:  
> The links from the two 'Bookmarks toolbar folder' should have merged.

Comment 2

[zug_treno]

*** Bug 316975 has been marked as a duplicate of this bug. ***

Comment 3

[Geert Poels]

Inactivity for a year and the bug still present in FF 1.5.

Import the same file three times :
You'll have all your entries three times.
It couldn't be so hard to check for doubles and do the merge (after a warning dialog).

Comment 4

[Chris Spencer]

Like Geert and others have mentioned, the real problem here is not enforcing any bookmark uniqueness (although having a non-deletable "Bookmarks Toolbar Folder" is quite annoying). The manager should really be changed so you'd get a prompt for each detected duplicate asking something like "Keep Existing | Overwrite Existing | Add", with a "do this for all files" checkbox option.

Comment 5

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 6

[Steve England [:stevee]]

Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!

Comment 7

[Michael Stather]

Yes I do and it would be nice if it could be fixed.

Comment 8

[Tracy Walker [:tracy]]

confirmed with 2.0.0.4

(this is not an issue on the trunk)

sort of work-around: after import move all the items in the imported Bookmarks toolbar folder into the permanent Bookmarks toolbar folder, then delete the now empty imported one.

Comment 9

[Chris Spencer]

Tracy, the purpose of this bug report is because this work around shouldn't be necessary. There's no reason why the import script can't simply merge the two folders together, saving the user from this trivial work. I'm using Firefox 2.0.0.4 and I still notice this problem.

Comment 11

[AHJ]

This Bug was posted Before two years and half

Comment 12

[Michael Stather]

Yes and this is exactly the problem :( (as with several other bugreports I also reported)

Comment 14

[Marco Bonardo [:mak]]

This bug is unlikely to still exists, since most of the code was rewritten it would be better to have a new bug with proper steps if something similar should still happen, even if I doubt it.