278149 - calIRecurrenceInfo.getNextOccurrence should use > aStartTime

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

88   // return the next display item for the event,
 89   // where the start time is >= aStartTime
 90   calIItemOccurrence getNextOccurrence (in calIDateTime aOccurrenceTime);

If that >= would be >, it would be easier to find the next occurence, since you
can pass in the start time of the previous occurence. You can use the end time,
but that will fail on overlapping items (a 1 hour item recurring every 15 minutes)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 171146 [details] [diff] [review]
patch

r=vladimir, looks good, land away

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 171146 [details] [diff] [review]
patch

Er wait, it's late.. calRecurrenceDate.cpp and calRecurrenceDateSet.cpp need
the change as well.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v2

ok, patch updated.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 171282 [details] [diff] [review]
patch v2

r=me, please check in

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in