Closed Bug 278157 Opened 20 years ago Closed 20 years ago

Need to correct xsl:number implementation

Categories

(Core :: XSLT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: peterv, Assigned: peterv)

References

()

Details

Attachments

(1 file)

We need to follow erratum 24 (probably by changing
http://lxr.mozilla.org/seamonkey/source/extensions/transformiix/source/xslt/txXSLTNumber.cpp#72).
I stumbled on this because Xalan has updated its test suite to follow that erratum.
I don't get it, looking at the code it seems like we're doing the right thing?
Oh, or should we not add the head and tail? The spec is awefully vague on that.
Attached patch v1Splinter Review
Attachment #173898 - Flags: review?(bugmail)
Comment on attachment 173898 [details] [diff] [review]
v1

nit, i'd do aResult = valueString just to be sure.

r=me either way
Attachment #173898 - Flags: review?(bugmail) → review+
Comment on attachment 173898 [details] [diff] [review]
v1

Yeah, I'll do |aResult = valueString;|.
Attachment #173898 - Flags: superreview?(jst)
Comment on attachment 173898 [details] [diff] [review]
v1

sr=jst
Attachment #173898 - Flags: superreview?(jst) → superreview+
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: