278157 - Need to correct xsl:number implementation

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Peter Van der Beken [:peterv]]

We need to follow erratum 24 (probably by changing
http://lxr.mozilla.org/seamonkey/source/extensions/transformiix/source/xslt/txXSLTNumber.cpp#72).
I stumbled on this because Xalan has updated its test suite to follow that erratum.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't get it, looking at the code it seems like we're doing the right thing?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Oh, or should we not add the head and tail? The spec is awefully vague on that.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 173898 [details] [diff] [review]
v1

nit, i'd do aResult = valueString just to be sure.

r=me either way

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 173898 [details] [diff] [review]
v1

Yeah, I'll do |aResult = valueString;|.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 173898 [details] [diff] [review]
v1

sr=jst