278200 - get rid of unnecessary warnings in nsIMIMEHeaderParameter::GetParameter (debug build)

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jungshik Shin]

|NS_ENSURE_SUCCESS(rv, rv)| keeps failing at netwerk/mime/src/
nsMIMEHeaderParamImpl.cpp:94 because it's invoked by the script loader for
Javascript version, but in most cases 'Content-Type' header for Javascript
doesn't have 'version' parameter. Therefore, nsIMIMEHeaderParameter->
GetParameter(..., 'version'...) fails most of time. 

We may as well change it to return zero-length string instead of returning the
failure code. 
It's also used heavily in mailnews so that we have to make sure changing it
doesn't break anything.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

but GetParameter did fail. how would you differentiate an empty parameter from a
not present parameter?

why not change the caller to not use NS_ENSURE_SUCCESS for something which may
legitimately return a failure code?

Comment 2

[Jungshik Shin]

Attachment: 1-liner

cbie, you're right. I should've used |if (NS_FAILED(rv)) return rv;| although
in optimized build, there's no difference.

Comment 3

[Darin Fisher]

Comment on attachment 171149 [details] [diff] [review]
1-liner

this looks good to me.	consumers of nsIMIMEHeaderParameter can NS_ENSURE_XXX
if they want, but since this function is used on unknown input it seems better
not to issue a warning on failure.

sr=darin

Comment 4

[Jungshik Shin]

Comment on attachment 171149 [details] [diff] [review]
1-liner

When loading pages with several external javascript files, warnings from this
can be quite bothering. We'd better get rid of it because most of time, it's
not an error but a legitimate failure.

Comment 5

[Jungshik Shin]

Comment on attachment 171149 [details] [diff] [review]
1-liner

thanks for sr.
crossed in 'mail'. clearing an extraneous sr request.

Comment 6

[Jungshik Shin]

landed in the trunk. (thanks for reviews)