278286 - Create Profile wizard title incomplete

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Alex Eng]

The title of the Create Profile Wizard (which appears when starting Mozilla for
the first time, with no profiles) is incomplete.  It reads:

    Welcome to the

Should read "Welcome to the Create Profile Wizard".

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

http://lxr.mozilla.org/seamonkey/source/toolkit/profile/locale/createProfileWizard.dtd#1

For some reason, then, newProfile.title is missing or isn't being read?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is handled at:
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/bindings/wizard.xml#340
and the corresponding dtd is:
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/locale/en-US/win/wizard.properties#5

When did this regress?

Comment 3

[Alex Eng]

Seems to have regressed between the 1.8a3 and 1.8a5 releases.  I'm having
difficulty downloading 1.8a4 from the FTP servers; I'll try again later today
and see if I can narrow the regression window further.

Comment 4

[[e-mail]]

Attachment: Proposed patch

The XBL in wizard.xml tries to get the document's title from its constructor,
however I'm guessing that that gets invoked by StartLayout so I need to ensure
that the title gets set first. At least, it seems to work ;-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171258 [details] [diff] [review]
Proposed patch

Hmm... ok, r+sr=bzbarsky

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[djpohly]

*** Bug 276684 has been marked as a duplicate of this bug. ***

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on Windows XP with build 2005-01-07-07, Seamonkey trunk.