278301 - sroaming should use localeVersion from chrome-versions.sh

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Roaming, defect)

Description

[Robert Kaiser]

L10n for sroaming doesn't work correctly right now as it has
localeVersion="0.9.4" in chrome.rdf when it should use the one from
chrome-versions.sh

I'll make up a patch shortly.

Comment 1

[Robert Kaiser]

Attachment: Patch: use the XUL preprocessor to insert localeVersion

This patch should resolve that bug - I haven't tested/compiled it yet, it's a
trivial change though and should work without problems...

Comment 2

[Robert Kaiser]

Attachment: Patch v2: Insert global localeVersion into contant and locale contents.rdf

the first compiles right but does only half the work... Of course, we have to
insert the correct localeVersion into both the content and the locale
contents.rdf files. Sorry, I was too much in a hurry when doing the first
patch.

Comment 3

[Ben Bucksch (:BenB)]

Comment on attachment 171305 [details] [diff] [review]
Patch v2: Insert global localeVersion into contant and locale contents.rdf

assuming this works (havn't tested)

Comment 4

[[e-mail]]

Comment on attachment 171305 [details] [diff] [review]
Patch v2: Insert global localeVersion into contant and locale contents.rdf

Well the pref panels work :-)

Nit: all other contents.rdf files seem to have 9 spaces between #expand and
chrome: rather than the 18 or 8 you used.

Comment 5

[Robert Kaiser]

Checking in mozilla/extensions/sroaming/jar.mn;
/cvsroot/mozilla/extensions/sroaming/jar.mn,v  <--  jar.mn
new revision: 1.4; previous revision: 1.3
done
Checking in mozilla/extensions/sroaming/resources/locale/en-US/contents.rdf;
/cvsroot/mozilla/extensions/sroaming/resources/locale/en-US/contents.rdf,v  <--
 contents.rdf
new revision: 1.3; previous revision: 1.2
done
Checking in mozilla/extensions/sroaming/resources/content/contents.rdf;
/cvsroot/mozilla/extensions/sroaming/resources/content/contents.rdf,v  <-- 
contents.rdf
new revision: 1.3; previous revision: 1.2
done

Comment 6

[Robert Kaiser]

Sorry, I actually had checked in without adddressing Neil's comment, just
checked in a followup to fix whitespace, I hope I got it correct now.