278350 - tinderbox's showlog should send cache headers

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

since a build log never changes, it would be nice to send an Expires: header far
in the future, so that the browser can cache it. probably also a last-modified
header for when the log was created.

Comment 1

[timeless]

actually, it does, if you annotate it :)

Comment 2

[cls]

Attachment: v1.0

For the most part, the logs are static so they should be cached.  If someone wants to see an updated tinderbox comment, they are probably more likely to click on the star and get the pop-up window rather than reload the entire multi-megabyte log.  

This patch replaces the expires meta tag with Last-Modified & Expires headers.  The logs are set to expire 1 hour from when the page is loaded.

Comment 3

[cls]

Comment on attachment 224497 [details] [diff] [review]
v1.0

Hrm.  By checking the timestamp on the notes.txt, the cgi will cause all logs to show as updated whenever anyone adds any comment.  I don't like that but fixing it may require us to read & store the value of the notes before generating the last-mod date instead of doing everything on the fly as it currently does.

Comment 4

[cls]

/cvsroot/mozilla/webtools/tinderbox/showlog.cgi,v  <--  showlog.cgi
new revision: 1.20; previous revision: 1.19
done