Closed Bug 278376 Opened 20 years ago Closed 10 years ago

[PatchReader] When using PatchViewer with context, the footer is not displayed

Categories

(Bugzilla :: Attachments & Requests, defect)

Product:
Bugzilla
Component:
Attachments & Requests
Version:
2.19.1
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: Wurblzap, Unassigned)

References

(
URL
)

Details

This happens on b.m.o, but I don't know whether it's a regression. Clicking the
URL shows the effect.
*** Bug 324243 has been marked as a duplicate of this bug. ***
Assignee: myk → attach-and-request
Summary: When using PatchViewer with context, the footer is not displayed → [PatchReader] When using PatchViewer with context, the footer is not displayed
The problem is that PatchReader::AddCVSContext::end_patch() doesn't call

  $this->{TEMPLATE_PROCESSOR}->process($this->{FOOTER_TEMPLATE}, $this->{ARGS})
      || ::ThrowTemplateError($this->{TEMPLATE_PROCESSOR}->error());

so in context mode, the footer is never displayed. But I suppose it's not its job to call it. We should call PatchReader::DiffPrinter::template::end_patch() too but I don't know why it's not the case.
CVS related code has been removed, see bug 1068494.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.