278394 - links in rss feed are bad; missing update type

Status: RESOLVED FIXED

Description

[daneel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

the links look like this:
http://addons.update.mozilla.org//moreinfo.php?id=431&vid=1408

notice the double slash after the domain.  it looks like it is missing the
update type ("extension", "theme", etc.).  the links on the web page
http://addons.update.mozilla.org/ are fine.  just fix the rss feed.

Reproducible: Always

Steps to Reproduce:
1. go to http://addons.update.mozilla.org/
2. add the rss feed listed on the page to your news reader
3. refresh the feed from your news reader
4. click on one of the updates

Actual Results:  
you get sent to a "Not Found" error ("The requested URL /moreinfo.php was not
found on this server...") screen.

Expected Results:  
launched the page where i can download the update that i clicked on from my news
reader.

Comment 1

[alanjstr]

Has this ever worked when type isn't provided?  The only version I see in LXR
requires typeName and the SQL query doesn't even pull type from the resultset. 

Comment 2

[daneel]

(In reply to comment #1)
> Has this ever worked when type isn't provided?  The only version I see in LXR
> requires typeName and the SQL query doesn't even pull type from the resultset. 

I think type is provided with the record, it's just not showing up in the URL. 
For example, an item in the rss feed contains a <link> node with a value of:

http://addons.update.mozilla.org//moreinfo.php?id=431&vid=1408

...but the link should be:

http://addons.update.mozilla.org/extensions/moreinfo.php?id=431&vid=1408

Comment 3

[alanjstr]

Reassigning to default assignee

Comment 4

[alanjstr]

Created attachment 172127 [details] [diff] [review]
Pull in Main.type and reuse code

Yes, I know you hate it when I do both at the same time.  This patch is for
trunk.	Branch will be more simple.

Comment 5

[alanjstr]

I don't have a copy of branch.  Here's the changes required.

rss/index.php:
$select = "SELECT DISTINCT 
main.ID, 
main.Name AS Title, 
main.Type,

rss/inc_rssfeed.php:
$types = array("E"=>"Extensions","T"=>"Themes","U"=>"Updates","P"=>"Plugins");
$listType = $types["$type"];

$itemtype = $row["Type"];

echo "      <link>http://$sitehostname/" . types["i$itemtype"].
"/moreinfo.php?id=" . $id . "&amp;vid=" . $vid . "</link>\n";

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172127 [details] [diff] [review]
Pull in Main.type and reuse code

://$sitehostname/" . types["i$itemtype"]. "/moreinfo.php?id=" . $id .
"&amp;vid=" . $vid . "</link>\n";

i$itemtype?

+//echo "<!-- $sql --";
Fix that please

the rest looks ok.

Comment 7

[alanjstr]

Created attachment 172143 [details] [diff] [review]
nits fixed

Comment 8

[alanjstr]

Created attachment 172193 [details] [diff] [review]
Diff for branch

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172193 [details] [diff] [review]
Diff for branch

+ maint.Type,

shouldn't that be "main.Type,"?

Comment 10

[alanjstr]

Created attachment 172624 [details] [diff] [review]
removed t

Comment 11

[alanjstr]

r=CTho

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172624 [details] [diff] [review]
removed t

r=cst

Comment 13

[alanjstr]

*** Bug 287673 has been marked as a duplicate of this bug. ***

Comment 14

[Colin Ogilvie [:cso]]

I've just seen this bug mentioned in #umo, but the patch won't apply ATM. New
patch coming up shortly.

Comment 15

[Colin Ogilvie [:cso]]

Created attachment 181071 [details] [diff] [review]
Unbitrotted Patch

Unbit rot patch and add WEB_PATH to the URL.

Demo at
https://update-staging.mozilla.org/~colin/update/rss/?application=firefox&list=newest

Comment 16

[Michael Morgan [:morgamic]]

Landed - will be pushed on next update.

Comment 17

[alanjstr]

*** Bug 291387 has been marked as a duplicate of this bug. ***

Comment 18

[Colin Ogilvie [:cso]]

*** Bug 291637 has been marked as a duplicate of this bug. ***

Comment 19

[Colin Ogilvie [:cso]]

*** Bug 291892 has been marked as a duplicate of this bug. ***

Comment 20

[blujay]

Well, sorry for submitting a dupe, but when I search for "rss" on the Update
component when preparing to submit a new bug, this one doesn't come up.  :/