Closed
Bug 278394
Opened 20 years ago
Closed 20 years ago
links in rss feed are bad; missing update type
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: daneel, Assigned: Bugzilla-alanjstrBugs)
References
()
Details
(Whiteboard: landme)
Attachments
(1 file, 4 obsolete files)
1.96 KB,
patch
|
morgamic
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
the links look like this:
http://addons.update.mozilla.org//moreinfo.php?id=431&vid=1408
notice the double slash after the domain. it looks like it is missing the
update type ("extension", "theme", etc.). the links on the web page
http://addons.update.mozilla.org/ are fine. just fix the rss feed.
Reproducible: Always
Steps to Reproduce:
1. go to http://addons.update.mozilla.org/
2. add the rss feed listed on the page to your news reader
3. refresh the feed from your news reader
4. click on one of the updates
Actual Results:
you get sent to a "Not Found" error ("The requested URL /moreinfo.php was not
found on this server...") screen.
Expected Results:
launched the page where i can download the update that i clicked on from my news
reader.
Has this ever worked when type isn't provided? The only version I see in LXR
requires typeName and the SQL query doesn't even pull type from the resultset.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to comment #1)
> Has this ever worked when type isn't provided? The only version I see in LXR
> requires typeName and the SQL query doesn't even pull type from the resultset.
I think type is provided with the record, it's just not showing up in the URL.
For example, an item in the rss feed contains a <link> node with a value of:
http://addons.update.mozilla.org//moreinfo.php?id=431&vid=1408
...but the link should be:
http://addons.update.mozilla.org/extensions/moreinfo.php?id=431&vid=1408
Reassigning to default assignee
Assignee: bugtrap → Bugzilla-alanjstrBugs
Yes, I know you hate it when I do both at the same time. This patch is for
trunk. Branch will be more simple.
Attachment #172127 -
Flags: first-review?(cst)
I don't have a copy of branch. Here's the changes required.
rss/index.php:
$select = "SELECT DISTINCT
main.ID,
main.Name AS Title,
main.Type,
rss/inc_rssfeed.php:
$types = array("E"=>"Extensions","T"=>"Themes","U"=>"Updates","P"=>"Plugins");
$listType = $types["$type"];
$itemtype = $row["Type"];
echo " <link>http://$sitehostname/" . types["i$itemtype"].
"/moreinfo.php?id=" . $id . "&vid=" . $vid . "</link>\n";
Comment on attachment 172127 [details] [diff] [review]
Pull in Main.type and reuse code
://$sitehostname/" . types["i$itemtype"]. "/moreinfo.php?id=" . $id .
"&vid=" . $vid . "</link>\n";
i$itemtype?
+//echo "<!-- $sql --";
Fix that please
the rest looks ok.
Attachment #172127 -
Flags: first-review?(cst) → first-review-
Attachment #172127 -
Attachment is obsolete: true
Attachment #172143 -
Flags: first-review?(cst)
Attachment #172143 -
Flags: first-review?(cst) → first-review+
Attachment #172193 -
Flags: first-review?(cst)
Comment on attachment 172193 [details] [diff] [review]
Diff for branch
+ maint.Type,
shouldn't that be "main.Type,"?
Attachment #172193 -
Flags: first-review?(cst) → first-review-
Assignee | ||
Comment 10•20 years ago
|
||
Attachment #172193 -
Attachment is obsolete: true
Attachment #172624 -
Flags: first-review+
Assignee | ||
Comment 11•20 years ago
|
||
r=CTho
Comment on attachment 172624 [details] [diff] [review]
removed t
r=cst
Assignee | ||
Comment 13•20 years ago
|
||
*** Bug 287673 has been marked as a duplicate of this bug. ***
Comment 14•20 years ago
|
||
I've just seen this bug mentioned in #umo, but the patch won't apply ATM. New
patch coming up shortly.
Comment 15•20 years ago
|
||
Unbit rot patch and add WEB_PATH to the URL.
Demo at
https://update-staging.mozilla.org/~colin/update/rss/?application=firefox&list=newest
Attachment #181071 -
Flags: first-review?(mike.morgan)
Updated•20 years ago
|
Attachment #181071 -
Flags: first-review?(mike.morgan) → first-review+
Comment 16•20 years ago
|
||
Landed - will be pushed on next update.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Attachment #172624 -
Attachment is obsolete: true
Updated•20 years ago
|
Attachment #172143 -
Attachment is obsolete: true
Assignee | ||
Comment 17•20 years ago
|
||
*** Bug 291387 has been marked as a duplicate of this bug. ***
Comment 18•20 years ago
|
||
*** Bug 291637 has been marked as a duplicate of this bug. ***
Comment 19•20 years ago
|
||
*** Bug 291892 has been marked as a duplicate of this bug. ***
Comment 20•20 years ago
|
||
Well, sorry for submitting a dupe, but when I search for "rss" on the Update
component when preparing to submit a new bug, this one doesn't come up. :/
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•