278414 - Cannot add 'cc' notification for Flags when using emailsuffixes

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Peter Kay]

When using e-mail suffixes to append @host.com to e-mail addresses, one cannot
add an e-mail address ([e-mail]) to the CC list for a Flag.

One gets the error:

<bright red>
The e-mail address you entered ([e-mail]) didn't pass our syntax checking
for a legal email address. Enter only the username (the @host.com will be
appended). It must also not contain any of these special characters: \ ( ) & < >
, ; : " [ ], or any whitespace.
</bright red>

in editflagtypes.cgi, sub validateCCList, there's the line:
    foreach my $address (@addresses) { CheckEmailSyntax($address) }
CheckEmailSyntax checks against the parameter "emailregexp", which rejects
"[e-mail]".

According to the documentation, we allow arbitrary CC lists for Flags, so
"[e-mail]" should be valid.

If we allow arbitrary CC lists for Flags (why *do* we do that for flags but not
for normal CC lists?) then we will need a seperate way to validate the CC e-mail
addresses.

Comment 1

[Frédéric Buclin]

Marc, I reassign this bug to you. I will let you set the correct flags (if
necessary) and confirm this bug. CC'ing kiko who reviewed your patch in bug 277389.

Comment 2

[Marc Schumann [:Wurblzap]]

Removing dependency because it doesn't exist :)

CheckEmailSyntax is named incorrectly. Its name should be CheckLoginSyntax. We
need a real CheckEmailSyntax which doesn't care about emailregexp (which should
be called loginregexp -- but this change is imo out of scope of this bug).

Comment 3

[Marc Schumann [:Wurblzap]]

I'm not currently working on this... I'll take it if/when I do. Until then, it's
up to grabs.

Comment 4

[Max Kanat-Alexander]

I'd like to see this fixed in 2.20 also, but I don't think it's severe enough to block the 2.22 release. We've lived with it OK in 2.20. People who use emailsuffix should only rarely have a need to CC somebody on a flag who isn't inside the company.

Comment 5

[Marc Schumann [:Wurblzap]]

The effect of this bug is that installations using emailsuffix can't use the CC feature of flags at all.

Comment 6

[Max Kanat-Alexander]

Oh, OK. In that case, it makes more sense to block 2.22 on it.

Comment 7

[Frédéric Buclin]

Attachment: patch for tip, v1

Comment 8

[Frédéric Buclin]

Attachment: patch for 2.20, v1

Comment 9

[Marc Schumann [:Wurblzap]]

Frédéric filed bug 319953 to follow up.

Comment 10

[Frédéric Buclin]

tip:

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.30; previous revision: 1.29
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.144; previous revision: 1.143
done


2.20:

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.19.4.1; previous revision: 1.19
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.115.2.9; previous revision: 1.115.2.8
done