278422 - Image insert fails to get image

Status: VERIFIED DUPLICATE of bug 268311

(SeaMonkey :: Composer, defect)

Description

[Tracy Walker [:tracy]]

seen on Windows Mozilla Trunk build 2005-01-14-09-trunk

-open composer
-select Insert | Image
-click Choose File
-find and image to insert and click open

tested results:
no image path or Image preview is shown in the Image Propertites dialog. Can't
insert an image.

expected results:
the path of the selected image is move to the Images Propertied dialog as well
as an Image preview displayed, then allowed to instert the image into the document.

expected

Comment 1

[Tracy Walker [:tracy]]

This also affects inserting an image into Mail message compose

Comment 2

[sairuh (rarely reading bugmail)]

not a problem using gtk2 moz bits on linux fc2.

Comment 3

[sairuh (rarely reading bugmail)]

fwiw, was using 2005-01-14-06 linux bits.

Comment 4

[sairuh (rarely reading bugmail)]

this also works for marcia on mac.

Comment 5

[Frank Wein [:mcsmurf]]

This exception appears when selecting a image in the file picker (after clicking
on the open button):
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned
 failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFilePicker.displayDirector
y]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chro
me://editor/content/editorUtilities.js :: SaveFilePickerDirectory :: line 604"  d
ata: no]

Comment 6

[Frank Wein [:mcsmurf]]

Probably fallout from Bug 268311, timeless will look into this bug.

Comment 7

[Robert Kaiser]

I also don't see the bug with a gtk2 build that's patched to use the XUL
filepicker, pulled at approx. 2005-01-14-14

Comment 8

[Andrew Schultz]

linux/gtk1 build 2005011505 works fine as well.  I poked around the code and
pref settings trying to get it to fail as described in comment 5, but it always
worked fine.

people who are seeing this bug: if you start with a fresh profile, do you still
hit the bug the first time you try to insert an image?  The specific line in
comment 5 should be skipped on the first time through (with a pristine profile).

timeless said on IRC that he tested the codepath on windows and it seemed to
work, the image preview showed my image and everything and the file location was
properly prettified.

Comment 9

[[e-mail]]

I put in a couple of printfs into nsBaseFilePicker.cpp but that seems to return
NS_OK so I don't understand why XPConnect is returning an error.

Comment 10

[[e-mail]]

Doh, it's SetDisplayDirectory that's throwing the error...

Comment 11

[[e-mail]]

The error was caused by setting the display directory to an uninitialised file.
However the file was obtained by getting the display directory :-(

Comment 12

[Joe Sabash [:JoeS1]]

This bug exists for all TB zip builds after version 0.6+ (20050113) which puts
it right in line with https://bugzilla.mozilla.org/show_bug.cgi?id=268311
I have checked TB zip builds on 2005014-2005016 ,all come up with a blank image
source after the file picker file selection. Typing a local file location into
the Image properties box, avoiding the file picker works OK.
This is with Winxp sp2
Do we need a specific Thunderbird bug for this.

Comment 13

[Tracy Walker [:tracy]]

> people who are seeing this bug: if you start with a fresh profile, do you still
> hit the bug the first time you try to insert an image?  The specific line in
> comment 5 should be skipped on the first time through (with a pristine profile).

yes, a clean install with a new profile displays this problem even on the first
attempt to insert an image.

Comment 14

[timeless]

*** This bug has been marked as a duplicate of 268311 ***

Comment 15

[Tracy Walker [:tracy]]

verified dupe