278438 - Paste with formatting fails

Status: VERIFIED DUPLICATE of bug 278702

(Core :: DOM: Editor, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: 2005-01-14-09, Windows XP.

Steps to Reproduce:

1.  Load
https://bugzilla.mozilla.org/buglist.cgi?product=Core&product=Mozilla+Application+Suite&chfieldfrom=0d&chfieldto=Now&chfield=%5BBug+creation%5D
2.  Make a selection with the mouse from left to right of 4 or 5 rows of bugs.
3.  Attempt to paste into Composer or Mail Compose.

Expected Results:

Able to paste.

Actual Results:

Unable to paste WITH formatting (the default), however 'Paste without
formatting' works.

Comment 1

[Frank Wein [:mcsmurf]]

I get this exception when reproducing this bug (but no assertion so):
An error occurred executing the cmd_paste command
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [ns
IController.doCommand]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS
 frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 69"  da
ta: no]

Comment 2

[Frank Wein [:mcsmurf]]

This broke between 2004-12-07-06 and 2004-12-08-04
Bonsai link (+/-1 hour to go sure all checkins are included):
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-12-07+05%3A00%3A00&maxdate=2004-12-08+05%3A00%3A00&cvsroot=%2Fcvsroot
Maybe caused by Bug 244685?
BTW: It's the copying that's broken, not the insert. When you copy the data in
the clipboard with a old build before 2004-12-07 and paste it in a current
build, it still works.

Comment 3

[Frank Wein [:mcsmurf]]

David: Might it be that this bug is caused by your patch from Bug 244685? Your
patch seems to be the only checkin on that day that affected clipboard.

Comment 4

[David Gardiner]

It could well be..

Any clues as to what 'flavour' composer/mail is expecting?

I'll try and see if i can figure out what is going on.

-dave

Comment 5

[David Gardiner]

Ok, 
i just did a fresh (debug) build of mozilla from CVS..

I opened Mozilla, then launched Composer.

I selected some formatted text in Mozilla (including the suggestion above), 
copied it to the clipboard (Ctrl-C) and then pasted it in Composer (Ctrl-V)

Both times, the formatting was copied across fine.

So I can't reproduce this at the moment.

-dave

Comment 6

[David Gardiner]

Some further experimenting, and I can *sometimes* reproduce this.

It is very weird, and I can't narrow down exactly why it works sometimes and 
why it doesn't.

-dave

Comment 7

[Frank Wein [:mcsmurf]]

(In reply to comment #6)
> Some further experimenting, and I can *sometimes* reproduce this.
> 
> It is very weird, and I can't narrow down exactly why it works sometimes and 
> why it doesn't.

I think two things are important:
1. Always select from the left to the right (so you have to select the whole
table row)
2. Start selecting bugs in the middle of the page. If you start selecting at the
first bug (directly under the column headers), it sometimes (i think it depends
where you start the click&drag) copies one additional empty table row and then
it works. So start right in the middle of the bug list.

Comment 8

[David Gardiner]

Yes, your selection instructions work for me too.

I believe I've narrowed it down to changes made to the following files. If i 
retrieve the specified older versions, then it works ok:

content/base/public/nsCopySupport.h (1.9)
content/base/src/nsCopySupport.cpp (1.39)

Now to figure out why!

-dave

Comment 9

[David Gardiner]

Attachment: Dump of clipboard flavours with nsCopySupport.cpp 1.38

Comment 10

[David Gardiner]

Attachment: Dump of clipboard flavours with nsCopySupport.cpp 1.41

Both of these clipboard flavour dumps where taken using the same selected text
in Mozilla.

I think the significant difference appears to be the content for the
text/_moz_htmlinfo flavour.

-dave

Comment 11

[David Gardiner]

Attachment: Possible patch to fix this problem

This patch fixes this problem, but it is a bit of an odd workaround. I'm
wondering if there is some other issue with the nsHTMLCopyEncoder class where
the Init doesn't reset everything (or maybe you can't use it like that?)

-dave

Comment 12

[David Gardiner]

Comment on attachment 171498 [details] [diff] [review]
Possible patch to fix this problem

Folks, the patch for 278702 was just checked in
(http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=Mozilla
TinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotyp
e=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-20+15%3A20%3A00&maxda
te=2005-01-20+15%3A20%3A00&cvsroot=%2Fcvsroot), so if you wouldn't mind testing
out the next build available to confirm that this problem is fixed.

-dave

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

David: checked in where?
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/content/base/src/nsCopySupport.cpp
yields no such change on the Seamonkey trunk; also, where are the necessary
reviewal stamps?

Comment 14

[David Gardiner]

Stephen,
the patch for 278702 should fix this bug too...

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/content/base/src/nsDocumentEncoder.cpp

-dave

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Ah, yes, you had already marked the dependency; I apologize.  Thanks for fixing
this, I'll comment tomorrow as to what I'm seeing post-patching.  Thanks again!

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

*** This bug has been marked as a duplicate of 278702 ***