278532 - [PATCH] Port nullplugin dialog to 21st century

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[Jorn Baayen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20050109 Epiphany/1.5.4.90
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20050109 Epiphany/1.5.4.90

Attaching a patch which:
- splits nullplugin.c (for unix) up into nullplugin-gtk1.c and nullplugin-gtk2.c
- nullplugin-gtk1.c is basically identical to the old nullplugin.c, minus GTK2
ifdefs
- nullplugin-gtk2.c is a gtk2-only nullplugin with a GNOME HIG-compliant dialog
(depends on Gtk+ 2.6), and the plugin-missing icon is rendered from the gnome
icon theme. It also fixes the problem where the dialog is activated with other
mouse clicks besides only the left button (bug #270377).

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jorn Baayen]

Attachment: The patch

Comment 2

[Jorn Baayen]

Attachment: Screenshot of new nullplugin dialog

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

I really doubt that we want to require gtk 2.6...

Comment 4

[Jorn Baayen]

In that case it's not impossible to add a configure check for the gtk version,
ie if >= 2.6.0 define something like MOZ_ENABLE_GTK26, and if that is defined
use the new code, otherwise the old code including the GTK2 ifdefs.

Comment 5

[Boris Zbarsky [:bzbarsky]]

jst, would you be the right reviewer for this?

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

I'd feel inclined to review- this based solely on the fact that you either use
gtk2.6 or get the old gtk1 dialog.  That is broken.  The gtk2 stuff should exist
for all gtk2 versions.

Comment 7

[Johnny Stenback (:jst)]

I'm probably the guy to sr, once the gtk2 stuff is all good according to
caillon. But in general, the nullplugin shouldn't need to be ported anywhere, we
should just find a nice comfy place where it can RIP never to be used by anyone
ever again (i.e. the CVS Attic) :) Long live the plugin finder service :)

Comment 8

[Bastien Nocera]

Here's a small list of possible enhancements to the null plugin that could be
considered for the gtk2 version:
- working dnd (you could dnd from the plugin to another application to open it,
or to the desktop to copy it or bookmark it)
- right-click being handled (with a "copy location" menu item in the popup menu)
- that doesn't popup an annoying dialog when you try to scroll on top of it
(this information should be in the plugin itself, or a tooltip anyway)
- Have a way to make the file open in an application that handles this mime-type

Comment 9

[aravindm]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.4) Gecko/20100413 Firefox/3.6.4
Please update if you are able to still reproduce with the latest nightly build  ftp://ftp.mozilla.org/pub/firefox/nightly/latest-trunk/

Comment 10

[Justin Dolske [:Dolske]]

Bug 533891 is going to kill the default (null) plugin entirely.