278599 - focus doesn't switch to content area after clicking on bookmark item in sidebar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[u115577]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050114 Firefox/1.0+

When I press Enter key on bookmark item, the focus switches.
No problem with History Sidebar.

Reproducible: Always

Steps to Reproduce:
1. Open Bookmarks Sidebar
2. Click bookmark item

Actual Results:  
Focus remains on bookmark item.

Expected Results:  
Focus switches to content area.

Comment 1

[u115577]

Attachment: patch - fixes annoying focus

This is regression since 2004-07-29.
http://lxr.mozilla.org/mozilla/source/browser/components/bookmarks/content/bookmarksTree.xml#558


"this.focus()" has no meaning because "things like cut/copy/etc" are called by
right click (aEvent.button == 2, see line 523).

Comment 2

[Hugh Kennedy]

dup of bug 189938 ?

Comment 3

[u115577]

(In reply to comment #2)
> dup of bug 189938 ?

Bug 189938 is about Mozillla Suite and seems to be fixed - the focus correctly
switches to content area.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050116

This is bug in Firefox code.

Suite:
http://lxr.mozilla.org/mozilla/source/xpfe/components/bookmarks/resources/bookmarksTree.xml#392

Firefox:
http://lxr.mozilla.org/mozilla/source/browser/components/bookmarks/content/bookmarksTree.xml#519

Comment 4

[u115577]

... and not Mac only.

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 171417 [details] [diff] [review]
patch - fixes annoying focus

How odd. Vlad seems to have put that in himself, as part of his mostly bug
252875 checkin last July, but the comment isn't... er, was that where that was
supposed to go? Surely we don't get past the openBookmark() line doing anything
like cut/copy? Personally, I'd refocus the sidebar on a metaKey+click, but
that's just me.

To get anywhere with a patch, you need to ask a peer for review: since it's
Vlad's code and bug, he's the likely candidate.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

So, here's the problem.

You click on a bookmark in the sidebar.
That bookmark is selected *and opened*, since we open on single-click so we can
be like IE.
Focus goes to the content area.

Now, at this point, you have a bookmark visually selected.

What if you want to hit C-x/C-c to cut/copy it?  It's (almost) impossible to use
keyboard shortcuts to cut/copy/etc. in the sidebar without this patch, as the
focus will never be where you want it to be.

So that's the issue -- you can either have working copy/cut/etc shortcuts, or
you can have the content area get focused.

If we weren't trying so hard to be like IE here, we'd just open on double-click
like any sane tree, and this problem goes away.  Gonna bounce the review to
mconnor, so he can pick his poison ;)

Comment 7

[Adam Hauner]

Is this bug related to bug 299514 (Random unresponsive keyboard shortcuts and
context menus due bad focus in tabs)?

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change