278636 - Confusing style of the name of the submitter of a comment/rating/review

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Alex Sirota (iosart)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

The name of the submitter of a comment/rating/review is displayed using the
same style/font/color as the title of the comment. This is a bit confusing IMHO.
For example: Dave submits a comment and says "Great extension". His comment will
say "Great extension by Dave",  etc.



Reproducible: Always

Comment 1

[Wolf [:wolf]]

Agreed. 

Comment 2

[Alex Sirota (iosart)]

Attachment: A tweak that solves this issue (part 1/3)

A tweaked version can be seen at:
http://update.iosart.com/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=456


two more patch parts to follow

Comment 3

[Alex Sirota (iosart)]

Attachment: A tweak that solves this issue (part 2/3)

Comment 4

[Alex Sirota (iosart)]

Attachment: A tweak that solves this issue (part 3/3)

Comment 5

[alanjstr]

Comment on attachment 171998 [details] [diff] [review]
A tweak that solves this issue (part 2/3)

Remove the span tags.

Comment 6

[alanjstr]

Also, it's easier to see how changes are applied by having them all in one 
patch instead of three.

Comment 7

[Alex Sirota (iosart)]

(In reply to comment #5)
> (From update of attachment 171998 [details] [diff] [review] [edit])
> Remove the span tags.
> 
the span tags are there so the style can later be changed in the style sheet
without needing to modify the code. what do you think?

Comment 8

[Alex Sirota (iosart)]

Attachment: Ditched the spans

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

trunk:
Checking in mozilla/webtools/update/css/cavendish/content.css;
/cvsroot/mozilla/webtools/update/css/cavendish/content.css,v  <--  content.css
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/webtools/update/extensions/moreinfo.php;
/cvsroot/mozilla/webtools/update/extensions/moreinfo.php,v  <--  moreinfo.php
new revision: 1.27; previous revision: 1.26
done
Checking in mozilla/webtools/update/themes/moreinfo.php;
/cvsroot/mozilla/webtools/update/themes/moreinfo.php,v  <--  moreinfo.php
new revision: 1.23; previous revision: 1.22
done


branch:
Checking in mozilla/webtools/update/css/cavendish/content.css;
/cvsroot/mozilla/webtools/update/css/cavendish/content.css,v  <--  content.css
new revision: 1.4.2.1; previous revision: 1.4
done
Checking in mozilla/webtools/update/extensions/moreinfo.php;
/cvsroot/mozilla/webtools/update/extensions/moreinfo.php,v  <--  moreinfo.php
new revision: 1.26.2.1; previous revision: 1.26
done
Checking in mozilla/webtools/update/themes/moreinfo.php;
/cvsroot/mozilla/webtools/update/themes/moreinfo.php,v  <--  moreinfo.php
new revision: 1.22.2.1; previous revision: 1.22
done