278672 - can't build myspell on Solaris using SunONE Studio compiler

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Kyle Yuan]

The fix for bug 240600 breaks the Solaris build, error messages are:

"affixmgr.hxx", line 54: Error: FILE is not defined.
"affixmgr.hxx", line 55: Error: FILE is not defined.
"affixmgr.hxx", line 56: Error: FILE is not defined.
"affentry.cpp", line 29: Error: The function "memcpy" must have a prototype.
"affentry.cpp", line 39: Error: The function "free" must have a prototype.
<snip>

Comment 1

[Kyle Yuan]

Attachment: proposed patch

Sun compiler needs |using namespace std;| to be in place.

The reason why sun boxes in the tinderbox port page are all green is none of
them are using SunONE studio compiler, they all are using gcc.

Comment 2

[Scott MacGregor]

Comment on attachment 171472 [details] [diff] [review]
proposed patch

Can you add some lines to README.mozilla that mentions the files and lines you
changed for this patch? The problem is we copy these files straight out of the
open office reposotory whenever we want to synch up with the latest myspell
changes going forward. And we'll forget to make your changes if we don't see
the comments in README.mozilla the next time we update....

Comment 3

[Kyle Yuan]

no problem, once mvl gave the patch r=, I will do it.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Why does it need namespace std?
To me the errors look more like a missing #include (but i don't know anything
about solaris)

Comment 5

[Kyle Yuan]

no, the prototypes are there, but they are all in the std:: namespace. the
implementations of standard c++ header are different between gcc and SunOne
compiler. I don't know the reason.
For OOo, they have their own stlport layer which can isolate the header files
from the system, i.e. stlport makes all those header files, such as cstdio,
cstring, system independent, that's why myspell can build in OOo without any
problem.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 171472 [details] [diff] [review]
proposed patch

But if namespace std is needed, why isn't it needed in other places? (or am i
just not looking good enough?)

And OOo-myspell compiles, because the original files did have the namespace
set.

Anyway, r=mvl

Comment 7

[Kyle Yuan]

(In reply to comment #6)
> (From update of attachment 171472 [details] [diff] [review] [edit])
> But if namespace std is needed, why isn't it needed in other places? (or am i
> just not looking good enough?)

That's because I added |using namespace std| in a header file - affixmgr.hxx.

Thanks for the r=. I'll check this patch in tomorrow and make some notes in
readme.mozilla.

Comment 8

[Kyle Yuan]

checked in.

Comment 9

[Andreas Lange]

*** Bug 278817 has been marked as a duplicate of this bug. ***