278691 - Implement undetectable window.external.addFavorite

Status: RESOLVED DUPLICATE of bug 29770

(Core :: DOM: Core & HTML, enhancement)

Description

[Marek Stępień [:marcoos, inactive]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7.5) Gecko/20041108 Firefox/1.0

Bug 248549 introduced undetectable document.all support in Firefox 1.0 and
Mozilla 1.7.5/1.8aX. This partially improves compatibility with Internet
Explorer. A logical step would be to implement window.external.addFavorite() as
a function that opens the chrome://browser/content/bookmarks/addBookmark2.xul
dialog.

This should be undectectable, because some sites use if (window.external) to
check for IE.

I think we could reuse the code for Firefox's window.sidebar.addPanel() method,
since sidebar panels are bookmarks in Firefox.

This enhancement is not intrusive and doesn't break anything in any website, but
improves the experience for new users, who usually are not happy that "add to
favorites" links don't work.


Reproducible: Always

Steps to Reproduce:
1. Go to a website with an "add to favorites" button
2. Click it


Actual Results:  
Nothing happens.

Expected Results:  
An "add bookmark" dialog should appear, just as if you clicked a link to
window.sidebar.addPanel().

Microsoft's spec:
http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/addfavorite.asp

Comment 1

[Marek Stępień [:marcoos, inactive]]

Whooops, sorry for submitting this bug as "new" and not "unconfirmed"...

Comment 2

[Anne (:annevk)]

This is a duplicate of bug 29770. Maybe someone wants to reconsider it and
implement it anyway, but I guess not.

Comment 3

[Nickolay_Ponomarev]

*** Bug 279320 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** This bug has been marked as a duplicate of 29770 ***