278711 - An empty entry is sometimes not useful and should be removed

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Vlad Dascalu]

Bug 255428 caused to show a multiple selection list where the first entry is an
empty line. This is not practical and the first line (the empty one) should be
removed in some cases, like in the case of "Add CC".

Comment 1

[John Beranek]

Ah yes, the usage of userselect.html.tmpl in bug/edit.html.tmpl shouldn't use
emptyok, should it...

Comment 2

[John Beranek]

Attachment: Bugzilla patch for tip

A patch to remove the blank line in the multiselect for "Add CC" on the edit
bug page.

Comment 3

[John Beranek]

Oh, and strictly the blank line was there before my patch in bug 255428, so this
wasn't a regression.

Comment 4

[John Beranek]

Actually, no, I understand now. When the addcc was a single dropdown, it needed
emptyok, now that's it's a multiple select it doesn't. I get it now.

Comment 5

[John Beranek]

Attachment: Bugzilla patch for tip - attempt 2

Second attempt at a patch to remove unnecessary blank lines in multiselects for
CCs. There shouldn't be a blank line in the CC field in the create bug page
either.

Comment 6

[Shane H. W. Travis]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
  edit.html.tmpl
new revision: 1.51; previous revision: 1.50
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tm
pl,v  <--  create.html.tmpl
new revision: 1.40; previous revision: 1.39
done

Comment 7

[Bo Zhang]

yes, thank you.

Comment 8

[Marc Schumann [:Wurblzap]]

*** Bug 286550 has been marked as a duplicate of this bug. ***