278717 - Can't create "create bug" template with multiple CCs if you use usemenuforusers

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[John Beranek]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041110 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041110 Firefox/1.0

Due to the checkin of the patch for bug 255428 you can no longer create a
bookmarkable "create bug" template with more than one CC entry if you set the
"usemenuforusers" param to "on".

This is because the combination of enter_bug.cgi and userselect.html.tmpl don't
allow for multiple initial selections in the CC multiselect.


Reproducible: Always

Steps to Reproduce:
1. Ensure you're using an installation of Bugzilla with the "usermenuforusers"
param set to "on".
2. Go to the create bug page, select more than one CC person and click "Remeber
values as bookmarkable template".
3. Click the link gets generated.

Actual Results:  
The create bug page generated by step 3 does not have all of the users you
selected in the CC box in step 2 selected. Only the first selected user is.


Expected Results:  
The create bug page generated by step 3 should have all the users you selected
for CC in step 2 selected.

Comment 1

[Vlad Dascalu]

Do you mean the CC entry or the Add to CC entry?

I think the CC entry list remained unaffected.

Comment 2

[John Beranek]

I mean the "CC:" field in enter_bug.cgi

I've been looking at the problem but can't see how you're meant to get a
multivalue form entry into a template.

Comment 3

[John Beranek]

What I have determined is that the "value" input parameter to
global/userselect.html.tmpl is either going to need to be changed to be an
array(ref) or a new input parameter will need to be added.

Comment 4

[John Beranek]

To try to clarify further, what I mean is that enter_bug.cgi will create a
"bookmarkable template" of the form:

enter_bug.cgi?product=...&...&cc=user1&cc=user2&...

However, enter_bug.cgi doesn't handle 'cc' having more than one value, and even
if it did, userselect.html.tmpl doesn't handle selecting more than one entry in
a multiselect box.

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Coping with user lists, using pattern matching.

Comment 6

[John Beranek]

Works well on my installation.

You've done it a way I'd considered but not yet attempted. Quite a tidy way to
do it, it turns out.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 171762 [details] [diff] [review]
Patch

This patch has bitrotted, but when I unrotted it, I couldn't get it to work for
me.  I probably was doing something wrong, though.  Can you post an updated
patch?

Comment 8

[Marc Schumann [:Wurblzap]]

Attachment: Unrotted

Comment 9

[John Beranek]

Attachment: Updated patch

How about this. It's untested as I haven't got a tip installation of Bugzilla
at the moment.

Comment 10

[John Beranek]

Woah, you wait ages for a patch and then 2 come along... :)

Comment 11

[Frédéric Buclin]

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.112; previous revision: 1.111
done
Checking in template/en/default/global/userselect.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/userselect.html.tmpl,v
 <--  userselect.html.tmpl
new revision: 1.5; previous revision: 1.4
done