If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stack overflow in mail client while checking for new POP mail

RESOLVED FIXED in mozilla1.8beta1

Status

()

Core
Layout: View Rendering
--
critical
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Andrei, Assigned: bz)

Tracking

({crash})

Trunk
mozilla1.8beta1
x86
Windows XP
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111

I have experienced multiple times crashes in the mail client while
checking/receiving mail. The last time my debugger reported a stack overflow.

I have quick launch activated.
I usually have one or several browser windows open when the crash occurs.


Reproducible: Sometimes

Comment 1

13 years ago
Can you provide a talkback id (start components/talkback.exe in your Mozilla
folder after sending the talkback incident)?

Updated

13 years ago
Keywords: crash
Version: unspecified → Trunk
(Reporter)

Comment 2

13 years ago
(In reply to comment #1)
> Can you provide a talkback id (start components/talkback.exe in your Mozilla
> folder after sending the talkback incident)?

I did what you suggested and -> TB3135104H

Comment 3

13 years ago
the view manager seems to be recursing infinitely - here are a couple iterations
from the stack trace:

GDI32.dll + 0x58ec (0x7f0058ec)
GDI32.dll + 0x5839 (0x7f005839)
nsDrawingSurfaceWin::Init 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/gfx/src/windows/nsDrawingSurfaceWin.cpp,
line 451]
nsRenderingContextWin::CreateDrawingSurface 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/gfx/src/windows/nsRenderingContextWin.cpp,
line 1020]
nsViewManager::RenderViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1344]
nsViewManager::Refresh 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 945]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1102]
nsWindow::Invalidate 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 2662]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1774]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1825]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1650]
nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1102]
nsWindow::Invalidate 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 2662]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1774]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1825]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1650]
nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]

Updated

13 years ago
Assignee: sspitzer → roc
Component: MailNews: Main Mail Window → Layout: View Rendering
Product: Mozilla Application Suite → Core
QA Contact: ian

Comment 4

13 years ago
*** Bug 279127 has been marked as a duplicate of this bug. ***
Blocks: 279804
So I don't understand on thing here... This part of the stack:

nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]

There is no call to UpdateViews in DispatchEvent (either now, or on Jan 11,
which is when that build is from).  There's nothing remotely like DispatchEvent
on line 1946.

The only place I can sort of see us recursing is if we end up in the
mRecursiveRefreshPending thing while handling a sync paint.  We'll trigger
UpdateAllViews with a sync paint, and recurse sort of like this (with a
different callstack, though...)
Created attachment 173403 [details] [diff] [review]
This may help...

roc, what do you think?
Attachment #173403 - Flags: superreview?(roc)
Attachment #173403 - Flags: review?(roc)
Attachment #173403 - Flags: superreview?(roc)
Attachment #173403 - Flags: superreview+
Attachment #173403 - Flags: review?(roc)
Attachment #173403 - Flags: review+
I checked in the patch.  Could someone who could reproduce the bug retest with
tomorrow's builds?

Comment 8

13 years ago
(In reply to comment #5)
> So I don't understand on thing here... This part of the stack:
> 
> nsViewManager::UpdateViews 
>
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
> line 1858]
> nsViewManager::DispatchEvent 
>
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
> line 1946]

Is this not related to the little "biff" pop-up that notifies you of when mail
arrives as I mentioned in 279127 and 279804?
OK, going to mark this fixed, per comments in bug 279804.
Assignee: roc → bzbarsky
Target Milestone: --- → mozilla1.8beta
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.