278819 - some styles is redundant in checkbox.css

Status: VERIFIED INVALID

(Core :: XUL, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111

There are redundant styles in checkbox.css. If there is style -moz-appearence on
element then background and border styles are unused. In instance thease styles
(checkbox.css) are unused:

/* ..... checked state ..... */ 

checkbox[checked="true"] > .checkbox-check {
  background-image: url("chrome://global/skin/checkbox/cbox-check.gif");
}

checkbox[checked="true"][disabled="true"] > .checkbox-check {
  background-image: url("chrome://global/skin/checkbox/cbox-check-dis.gif")
!important
} 

style for class checkbox-check can be replaced with
.checkbox-check {
  -moz-appearance: checkbox; 
}

I think there are redundant styles not only for checkbox. It is need to check
styles for other elements like textbox or toolbarbutton.

Reproducible: Always

Steps to Reproduce:

Comment 1

[alexander :surkov (:asurkov)]

Attachment: checkbox binding override styles

Comment 2

[alexander :surkov (:asurkov)]

Attachment: overrided styles

compare this checkbox.css with global/skin/checkbox.css

Comment 3

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 4

[timeless]

not everyone implements -moz-appearance.

Comment 5

[alexander :surkov (:asurkov)]

What do you mean by everyone? os or something else?

Comment 6

[[e-mail]]

Native themes are only supported on the three major OSes.