278896 - Move patches from branch to trunk

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

checking in reviewed patches from the XFORMS_20050106_BRANCH to the trunk. 
patches for:
265931
263384
277475
275227
278092
265467
278433

Comment 1

[Doron Rosenberg (IBM)]

Attachment: Big Patch

bryner - I need sr for the configure.in change (add schema-validation to
MOZ_EXTENSIONS_ALL) only.  Thanks!

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 171693 [details] [diff] [review]
Big Patch

You should make xforms not be built if schema-validation isn't given as an
extension.  Should be a copy and paste of what we're already doing for xtf and
webservices.

Comment 3

[Doron Rosenberg (IBM)]

Attachment: make sure schema-validation is being built.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 171694 [details] [diff] [review]
make sure schema-validation is being built.

sr=me for the configure changes

Comment 5

[Allan Beaufour]

I know it's a much bigger job (/pain), but shouldn't we check them in one at a time?

Comment 6

[Doron Rosenberg (IBM)]

checked in, linux/mac cycled fine.

The problem with checking them in one in a time is that it is as you mention a
pain.  And since some tinderboxen cycle fast, you end up with missing parts so
they go red, etc.

Comment 7

[Allan Beaufour]

(In reply to comment #6)
> checked in, linux/mac cycled fine.
> 
> The problem with checking them in one in a time is that it is as you mention a
> pain.  And since some tinderboxen cycle fast, you end up with missing parts so
> they go red, etc.

But we would have had a correct history. But too late now. Just to make it
easier to navigate, here are the bugs again, hopefully including hyperlinks:

* bug 265931
* bug 263384
* bug 277475
* bug 275227
* bug 278092
* bug 265467
* bug 278433

Comment 8

[Allan Beaufour]

I've closed all the bugs that have been checked in, except for bug 263384. As
far as I can see it is checked in, but the bug has a sr- from peterv?

Comment 9

[Allan Beaufour]

bug 277410 was also part of the check in.