278904 - keyword: search in URL bar with spaces prevents opening result links in new window or tab, causes urlSecurityCheck failure

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[siimo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050118 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050118 Firefox/1.0+

When using user_pref("keyword.URL", "http://www.google.com/search?q="); pref,
and searching a string in URL bar with spaces, all the links on the search
result page do not open if tired to open them in new windows or new tabs. they
do open in current window/tab

Reproducible: Always

Steps to Reproduce:
1. start with a clean profile and set the pref user_pref("keyword.URL",
"http://www.google.com/search?q=");
2. open firefox and type this in url bar without quotes: "mozilla firefox"   -
this should result in a google search results page with "keyword:mozilla
firefox" in the URL bar.
3. try to open any links on this search result page in a new window or new tab
by either using ctrl + click, or middle click or right click + open in new
window/tab

Actual Results:  
No new window or tab opens.

Expected Results:  
A new window or tab should open and load the page linked by the URL.

Comment 1

[sammy_c]

 Confirmed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b)
Gecko/20050211 Firefox/1.0+. You can reproduce this just by entering "keyword:
bug 278904" in the address bar.

 There is in error in the JavaScript console when you use control-click or
middle-click:

Error: uncaught exception: [Exception... "Component returned failure code:
0x804b000a [nsIURI.spec]"  nsresult: "0x804b000a (<unknown>)"  location: "JS
frame :: chrome://browser/content/contentAreaUtils.js :: urlSecurityCheck ::
line 94"  data: no]

 The search result links do open on an unmodified left-click so the search
results aren't completely "locked up", suggest the Submitter changes the
description to:

"keyword: search in URL bar with spaces prevents opening result links in new
window or tab, causes urlSecurityCheck failure"

Comment 2

[siimo]

thanks, done. 

Comment 3

[sammy_c]

 Confirm this is fixed in Firefox 1.0.1 released version (Mozilla/5.0 (Windows;
U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1).

Comment 4

[siimo]

Sammy_c,
This bug never existed on the 1.0 branch. It exists on the trunk, where
development for 1.1 release is happening. 

1.0.1 release of firefox was bugfixes to the 1.0 version which didn't have this bug.

Comment 5

[sammy_c]

 Oops, sorry. For what it's worth the reason it still works in Firefox 1.0.1 is
that the keyword search line in the address bar generated by entering search
words in the address bar converts spaces between words to "%20", so entering
"testing one two three" in the address bar creates a URL of
"keyword:testing%20one%20two%20three", which is apparently acceptable to the URL
security checker. Something changed in the trunk revisions that stops this
translation of spaces to "%20" happening. If you enter "keyword: one two three"
directly in the address bar in 1.0.1 it still does the search but the results
page has the same problem as in the bug description.

Comment 6

[siimo]

this seems to have fixed itself now (atleast on linux 20050325), probably as a
dependency of some other bug, as i see no checkins here. Can someone please
check this on windows/mac ?

Comment 7

[Tristor]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050325
Firefox/1.0+

Testing in latest-trunk on WindowsXP Pro SP1 Build 2600.

Following supplied steps for reproduction, I encounted no problems.  This is WFM.

Comment 8

[siimo]

marking WFM..