278913 - header file nptypes.h on HP-UX (11.00) breaks compilation

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[hawkinst]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040930
Build Identifier: Mozilla/5.0 (X11; U; HP-UX 9000/785; en-US; rv:1.7.5) Gecko/20050118

On HP-UX 11.00 systems the header file
mozilla/modules/plugin/base/public/nptypes.h does not include the correct system
header files for HP-UX.  

This results in a compilation error as follows:

Error 112: "../../../../dist/include/plugin/nptypes.h", line 98 # Include file
<stdint.h> not found.^M


There is no stdint.h on HP-UX 11.00, so the header file nptypes.h should include
a case for HP-UX, but it does not.  

Note that this is a new problem with Mozilla 1.7.5.  Previous versions 1.7 and
1.7.3 did not have this issue on HP-UX.



Reproducible: Always

Steps to Reproduce:
1. Extract mozilla-source-1.7.5.tar.bz2

2.  use the .mozconfig:
mk_add_options MOZ_OBJDIR=/pkg/mozilla/mozilla_1.7.5.dist/mozilla/
ac_add_options --prefix=/pkg/mozilla/mozilla_1.7.5.dist/mozilla/
ac_add_options --x-libraries=/usr/lib/X11R6
ac_add_options --x-include=/usr/include/X11
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --enable-optimize=+O2
ac_add_options
--with-default-mozilla-five-home=/pkg/mozilla/mozilla_1.7.5.dist/mozilla/
ac_add_options --without-system-nspr
ac_add_options --without-system-zlib
ac_add_options --without-system-jpeg
ac_add_options --without-system-png
ac_add_options --enable-crypto
ac_add_options --enable-calendar
ac_add_options --with-gtk-prefix=/pkg/gtk+/gtk+_1.2.10_hpux_cc.dist/gtk+
ac_add_options --with-glib-prefix=/pkg/glib/glib_1.2.10_hpux_cc.dist/glib
ac_add_options --with-libIDL-prefix=/pkg/libIDL/libIDL_0.6.8_hpux_cc.dist/libIDL
ac_add_options --enable-ldap
ac_add_options --enable-ldap-experimental


3. set the envionment to use the HP-UX compilers, and then: "cd mozilla && gmake
-f client.mk" to build as normal

Actual Results:  
compile error every time:

Error 112: "../../../../dist/include/plugin/nptypes.h", line 98 # Include file
<stdint.h> not found.^M
      #include <stdint.h>^M
               ^^^^^^^^^^^M
gmake[4]: Leaving directory
`/pkg/mozilla/mozilla_1.7.5.dist/mozilla/modules/plugin/base/src'^M


Expected Results:  
software should have included valid system header files and built succesfully.

WORK AROUND / SUGGESTED PATCH for 'nptypes.h'
-------------------------------------------------


change line #51 from:

#elif defined(_AIX) || defined(__sun) || defined(__osf__) || defined(IRIX)

to:

#elif defined(_AIX) || defined(__sun) || defined(__osf__) || defined(IRIX) ||
defined(__hpux)


with this simple change Mozilla 1.7.5 will now build and run on HP11.

this change works as:
 - this will include inttypes.h - which is a valid system header on HPUX
 - stdbool.h on HP11 is not compatible with Mozilla, so don't use it
 - instead the 'typedef int bool' works
 - ( the default (Broken) way is to only pull in 'stdint.h' ...)


I'm sorry I did not make a full on patch for this change... my bad.

Comment 1

[Johnny Stenback (:jst)]

The current trunk already has:

#elif defined(_AIX) || defined(__sun) || defined(__osf__) || defined(IRIX) ||
defined(HPUX)

Does that work for you? If so, this is fixed on the trunk...

Comment 2

[hawkinst]

Yes, that is fine.

I'm sorry, I did not check CVS too see that this had actually been fixed
already.  My bad...

Thanks for your work guys!  Mozilla/Firefox rocks!

Trevor