278936 - About and Credits dialogs still display 2004 (update to 2005)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2005011807-trunk firefox build on linux fc2 and mac os x 10.3.7.

select Help > About Mozilla Firefox

results: the About dialog still displays (copyright 1998-2004).

need to update 2004 to 2005. :)

Comment 1

[Chris Blore]

This appears to be locale-specific (unless I'm very much mistaken). I can put a
patch together for the en-US locale in that case but I think it's up to the
localization authors to do it for their own languages.

Comment 2

[Chris Blore]

Attachment: cookies page

Comment 3

[Chris Blore]

Attachment: customization page

Comment 4

[Chris Blore]

Attachment: download manager page

Comment 5

[Chris Blore]

Attachment: for ie users page

Comment 6

[Chris Blore]

Attachment: menu reference page

Comment 7

[Chris Blore]

Attachment: mouse shortcuts page

Comment 8

[Chris Blore]

Attachment: popup page

Comment 9

[Chris Blore]

Attachment: prefs page

Comment 10

[Chris Blore]

Attachment: shortcuts page

Comment 11

[Chris Blore]

Attachment: tabbed browsing page

Comment 12

[Chris Blore]

Attachment: using firebird page

Comment 13

[Chris Blore]

I've just made a rather big mistkake and checked in a whole lot of patches for
the wrong bug! Sorry!

Comment 14

[Chris Blore]

Attachment: patched about dialog to update copyright info

Comment 15

[Steffen Wilberg]

Chris, stop! I don't need patches to change that. Besides, these are not
patches. A patch is created using cvs diff -u <filename> <filename> <filename>...
Please don't attach complete files! And please remove all those review requests.

Comment 16

[Chris Blore]

Attachment: corrected about dialog

Comment 17

[Jesse Ruderman]

*** Bug 283417 has been marked as a duplicate of this bug. ***

Comment 18

[Steffen Wilberg]

Comment on attachment 172833 [details] [diff] [review]
corrected about dialog

The same change is needed for
mail/locales/en-US/chrome/messenger/aboutDialog.dtd.

I already added those locations to release-checklist.html.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 172833 [details] [diff] [review]
corrected about dialog

r=dbaron, but we need to fix the localizations too

Comment 20

[Steffen Wilberg]

> r=dbaron, but we need to fix the localizations too
cmp, can you help here please? I don't have an all-locales tree. I guess we want
this for the 1.0.x branch as well.

Comment 21

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/browser/aboutDialog.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/aboutDialog.dtd,v  <-- 
aboutDialog.dtd
new revision: 1.4; previous revision: 1.3
done

The l10n teams can adjust their locales by themselves on the trunk.

I also bumped the copyright date in Help docs to 2005.

Comment 22

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050305
Firefox/1.0+

Steffen,

Credits.xhtml still contains 2004

line 277
>&brandFullName;™ &license.part0; copyright ©1998-2004
                                                                ^
line 289
>This software may contain portions that are Copyright ©1998-2004
                                                                     ^

Comment 23

[Steffen Wilberg]

Sigh, reopening.

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Are all of these issues mentioned on
http://www.mozilla.org/build/release-checklist.html .  And are there bugs filed
on making these things easier?  (In particular, not having the copyright year in
localizations, and perhaps even having a substitution for it.)

Comment 25

[Steffen Wilberg]

browser/base/content/credits.xhtml and
mail/locales/en-US/chrome/messenger/credits.html were missing from
http://www.mozilla.org/build/release-checklist.html. I just added them.

I can't find a bug on making life easier. What do you suggest? Something like
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/configure.in&rev=1.1422&root=/cvsroot#6232?

Comment 26

[sairuh (rarely reading bugmail)]

Scott, I think this is also a bug in Tbird 1.0.x --not sure if there's a bug
filed for that product, lemme check...

Comment 27

[sairuh (rarely reading bugmail)]

ah yes, the thunderbird version is bug 283122.

Comment 28

[Daniel Veditz [:dveditz]]

So this ought to block Firefox 1.0.2, right?

Comment 29

[Daniel Veditz [:dveditz]]

Fixed trunk and aviary 1.0.1 branch

Comment 30

[Chase Phillips]

dveditz: I'm surprised you marked this fixed so soon.  Doesn't this need to be
changed in all of our localizations, as well, before we can mark it
fixed-aviary1.0.2?

Comment 31

[Steffen Wilberg]

Firefox's Credits dialog still displays 2004, see comment 22.

Comment 32

[Steffen Wilberg]

Attachment: fix Credits dialog

This is a trunk patch for Firefox's and Thunderbird's Credits dialogs.

Note that Scott already fixed one of the two 2004 dates in TB's credits.html on
the *trunk*:
http://bonsai.mozilla.org/cvsquery.cgi?branch=&file=credits.html&date=explicit&mindate=2005-03-15+10%3A40&maxdate=2005-03-15+10%3A40

This should be fixed on the branch as well.

Comment 33

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 177583 [details] [diff] [review]
fix Credits dialog

review+, but please get us a preprocessor-based solution to this for the trunk
before next year

Comment 34

[Steffen Wilberg]

Checking in mozilla/browser/base/content/credits.xhtml;
/cvsroot/mozilla/browser/base/content/credits.xhtml,v  <--  credits.xhtml
new revision: 1.8; previous revision: 1.7
done
Checking in mozilla/mail/locales/en-US/chrome/messenger/credits.html;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/credits.html,v  <-- 
credits.html
new revision: 1.8; previous revision: 1.7
done

Comment 35

[Steffen Wilberg]

Thunderbird's credits.html is now fixed on branch and trunk.

Firefox's credits.xhtml is fixed on the trunk, but needs branch approval and
checkin.

Comment 36

[chris hofmann]

Comment on attachment 177583 [details] [diff] [review]
fix Credits dialog

a=chofmann

Comment 37

[Steffen Wilberg]

1.0.1 branch checkin:
Checking in mozilla/browser/base/content/credits.xhtml;
/cvsroot/mozilla/browser/base/content/credits.xhtml,v  <--  credits.xhtml
new revision: 1.1.2.15.2.1; previous revision: 1.1.2.15
done

I think we've fixed Firefox's and Thunderbird's About and Credits dialogs on
branch and trunk *en-US*.

Who can help with the rest of our locales on the branch:
mozilla/browser/locales/en-US/chrome/browser/aboutDialog.dtd
mozilla/mail/locales/en-US/chrome/messenger/aboutDialog.dtd
mozilla/mail/locales/en-US/chrome/messenger/credits.html

No action is needed for mozilla/browser/base/content/credits.xhtml.

Comment 38

[Tracy Walker [:tracy]]

Firefox credits are correct with nightly builds from 03/16. As are Thunderbird
branch builds.

Comment 39

[Chase Phillips]

(In reply to comment #37)
> Who can help with the rest of our locales on the branch:
> mozilla/browser/locales/en-US/chrome/browser/aboutDialog.dtd
> mozilla/mail/locales/en-US/chrome/messenger/aboutDialog.dtd
> mozilla/mail/locales/en-US/chrome/messenger/credits.html
> 
> No action is needed for mozilla/browser/base/content/credits.xhtml.

Unfortunately it would take too long to try to mobilize all of our localizers to
fix this.  We just don't have the time to do this and involve them.

Instead, one or two people will need to go into each of the locales and make
these changes, then post the diff here for approval.  Teh suck and why I cared-
about this bug.

Comment 40

[Christian Schmidt]

> I can't find a bug on making life easier.

How about adding a &buildYear; entity?

Comment 41

[Chase Phillips]

(In reply to comment #25)
> I can't find a bug on making life easier.

FYI I filed a bug about making life easier for localizers:

  Bug 286312 - ensure localization customization is not insane

Comment 42

[Chase Phillips]

Attachment: update aboutDialog.dtd for locales on aviary branch

Update help is not in this patch.  I gather to gain parity we should update
those, as well?

Comment 43

[Chase Phillips]

Comment on attachment 177670 [details] [diff] [review]
update aboutDialog.dtd for locales on aviary branch

The following locales are updated by this patch:

  * af-ZA
  * ast-ES
  * ca-AD
  * cs-CZ
  * cy-GB
  * da-DK
  * de-DE
  * el-GR
  * en-GB
  * es-AR
  * es-ES
  * eu-ES
  * fi-FI
  * fr-FR
  * ga-IE
  * he-IL
  * hu-HU
  * it-IT
  * ja-JP
  * ja-JPM
  * ko-KR
  * lt-LT
  * mk-MK
  * nb-NO
  * nl-NL
  * pa-IN
  * pl-PL
  * pt-BR
  * pt-PT
  * ro-RO
  * ru-RU
  * sk-SK
  * sl-SI
  * sq-AL
  * sv-SE
  * tr-TR
  * zh-CN
  * zh-TW

Comment 44

[Chase Phillips]

(In reply to comment #37)
> mozilla/mail/locales/en-US/chrome/messenger/aboutDialog.dtd
> mozilla/mail/locales/en-US/chrome/messenger/credits.html

(for the record..) There are no mail/ locales for the aviary branch. 
Thunderbird 0.x - 1.0.x weren't configured to build official localizations from CVS.

Comment 45

[Chase Phillips]

Comment on attachment 177670 [details] [diff] [review]
update aboutDialog.dtd for locales on aviary branch

This is the first part of a two-part patch needed to bring localizations with
us into the year two double ought five.

Seeking r/a.

Comment 46

[chris hofmann]

Comment on attachment 177670 [details] [diff] [review]
update aboutDialog.dtd for locales on aviary branch

a=chofmann

Comment 47

[Chase Phillips]

Comment on attachment 177670 [details] [diff] [review]
update aboutDialog.dtd for locales on aviary branch

Landed on l10n aviary1.0 branch.

Checking in browser/locales/af-ZA/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/af-ZA/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ast-ES/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ast-ES/chrome/browser/Attic/aboutDialog.dtd,v 
<--  aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ca-AD/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ca-AD/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/cs-CZ/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/cs-CZ/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/cy-GB/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/cy-GB/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/da-DK/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/da-DK/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in browser/locales/de-DE/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/de-DE/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.6; previous revision: 1.1.2.5
done
Checking in browser/locales/el-GR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/el-GR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/en-GB/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/en-GB/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/locales/es-AR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/es-AR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/es-ES/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/es-ES/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/eu-ES/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/eu-ES/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/fi-FI/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/fi-FI/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/fr-FR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/fr-FR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ga-IE/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ga-IE/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/he-IL/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/he-IL/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/hu-HU/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/hu-HU/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/locales/it-IT/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/it-IT/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in browser/locales/ja-JP/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ja-JP/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ja-JPM/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ja-JPM/chrome/browser/Attic/aboutDialog.dtd,v 
<--  aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ko-KR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ko-KR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/locales/lt-LT/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/lt-LT/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/mk-MK/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/mk-MK/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/nb-NO/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/nb-NO/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in browser/locales/nl-NL/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/nl-NL/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in browser/locales/pa-IN/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/pa-IN/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/pl-PL/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/pl-PL/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/locales/pt-BR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/pt-BR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/pt-PT/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/pt-PT/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/ro-RO/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ro-RO/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/ru-RU/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/ru-RU/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/sk-SK/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/sk-SK/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/sl-SI/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/sl-SI/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in browser/locales/sq-AL/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/sq-AL/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/sv-SE/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/sv-SE/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/tr-TR/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/tr-TR/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Checking in browser/locales/zh-CN/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/zh-CN/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/locales/zh-TW/chrome/browser/aboutDialog.dtd;
/l10n/mozilla/browser/locales/zh-TW/chrome/browser/Attic/aboutDialog.dtd,v  <--
 aboutDialog.dtd
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 48

[Chase Phillips]

Adding fixed-aviary1.0.2 though we won't be able to verify until the l10n build
machines are shuffled back over to the aviary1.0.1 branch.  That will happen
within a day, give or take a couple of hours.

Comment 49

[Steffen Wilberg]

I don't think it's worth to bump the copyright date in Help Documentation on the
branch. Marking fixed.

By the way:
firefox -version results in
Mozilla Firefox 1.0.2, Copyright (c) 2004 mozilla.org
http://lxr.mozilla.org/seamonkey/search?string=Copyright+%28c%29+2004+Mozilla.or

Comment 50

[Chase Phillips]

(In reply to comment #49)
> By the way:
> firefox -version results in
> Mozilla Firefox 1.0.2, Copyright (c) 2004 mozilla.org
> http://lxr.mozilla.org/seamonkey/search?string=Copyright+%28c%29+2004+Mozilla.or

I filed bug 286957 on bumping this copyright in Firefox.

Comment 51

[:Gavin Sharp [email: [e-mail]]]

*** Bug 283525 has been marked as a duplicate of this bug. ***