278947 - Editing bookmark name to null state, or to ending in <colon><space>, blanks bookmarks

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you edit (by accident, or in the process of editing) a bookmark name to be
blank, or to a state where it ends in ": " (e.g., visit and bookmark the above
link, then edit the "Camino" part off), all of the bookmarks views immediately
become blank (no pressing return required).  History view remains ok.

Closing the entire window in which the Bookmarks Manager was opened restores
visibility the next time the BM is opened. 

2005011808 (v0.8+), Mac OS X 10.3.7.  (Also occured in the unofficial 20050117
build and seems likely a result of smfr's bookmarks/history fixes of the past
few days.)  This is a reproducible case of bug 174899 comment 11 issue b.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OK, it gets worse.  First, if the name ends in <colon> alone, the problem also
exists.

Second, it seems that once a bookmark has been edited in such a way to cause
this state, every subsequent editing also causes the state, even if the user is
careful not to delete the entire name, end on a <space> or <colon>, etc.

Also, by default the entire name is selected when entering editing mode, so
start typing and watch the BM view blank.

Editing the BM name with Ctrl-click and "Get Info" seems OK.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Aaaah, it's pretty awful now.  

I've just tried with a fresh profile, and it seems that *any* editing of the
bookmark name *or* URL causes the problem.

Essentially it seems editing in the Bookmarks Mgr is now broken :-(

Console is reporting things like:
2005-01-19 02:17:31.379 Camino[3570] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (7)
beyond bounds (0)
2005-01-19 02:17:31.379 Camino[3570] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (7)
beyond bounds (0)

2005-01-19 02:16:20.260 Camino[3563] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (11)
beyond bounds (0)
2005-01-19 02:16:20.260 Camino[3563] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (11)
beyond bounds (0)

2005-01-19 02:08:31.047 Camino[3555] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (8)
beyond bounds (0)
2005-01-19 02:08:31.047 Camino[3555] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (8)
beyond bounds (0)

2005-01-19 02:21:15.200 Camino[3577] Exception raised during posting of
notification.  Ignored.  exception: *** -[NSCFArray objectAtIndex:]: index (7)
beyond bounds (0)
(once only for editing just the bookmark URL, twice for the name, it seems)

It's unclear whether this warrants raising the severity to major or not; there
is a fairly easy work-around (always use Get Info to edit), but it otherwise
seems like a major loss of function.  Downgrade if I'm wrong :-)

Comment 3

[Simon Fraser [no longer active]]

I think I have a fix for this. When editing inline, the controlTextDidChange
notifications are being picked up by the quicksearch code, and it does a
quicksearch.

Comment 4

[Simon Fraser [no longer active]]

Fixed.