Nested repeats are not working

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
14 years ago
2 years ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
Hmmm, I do not think I have ever tested that functionality... nevertheless they
do not work :(
(Assignee)

Comment 1

14 years ago
Created attachment 171729 [details]
Testcase
(Assignee)

Updated

14 years ago
Blocks: 278209
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Depends on: 278973
(Assignee)

Comment 2

14 years ago
I've been investigating a bit, and it seems like DoneAddingChildren() is never
called for the cloned <repeat>s. So if I remove the mDoneAddingChildren check in
nsXFormsRefreshElement::Refresh(), nested repeats seems to work.

Anybody got a clue to why DoneAddingChildren is never called on the cloned nodes?

Comment 4

14 years ago
You could use BeginAddingChildren() to set mDoneAddingChildren false and
then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren
should be set true.
(Assignee)

Comment 5

14 years ago
(In reply to comment #4)
> You could use BeginAddingChildren() to set mDoneAddingChildren false and
> then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren
> should be set true.

Argh, of course. We have had that bug before somewhere else haven't we?

Thanks smaug!
(Assignee)

Comment 6

14 years ago
Created attachment 171872 [details] [diff] [review]
Simple patch

Here's a simple patch doing what smaug suggested.
(Assignee)

Updated

14 years ago
Attachment #171872 - Flags: review?(smaug)
(Assignee)

Comment 7

14 years ago
BTW, we could consider letting nsXFormsControlStub implement this more
generally, but let's do that on another bug.

Comment 8

14 years ago
Comment on attachment 171872 [details] [diff] [review]
Simple patch

This is ok, but needs also Bug 278973
Attachment #171872 - Flags: review?(smaug) → review+
(Assignee)

Comment 9

14 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.