If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Let nsIContextControl use nsIDOMNode instead of nsIDOMElement

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
13 years ago
a year ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
There's no reason for nsIContextControl to use nsIDOMElement as the context
node. The node a control is bound to and also uses as context is just a nsIDOMNode.
(Assignee)

Comment 1

13 years ago
Created attachment 171741 [details] [diff] [review]
Patch v1

Uses nsIDOMNode instead, and also solves some sloppy coding from me:
nsXFormsRepeatElement and nsXFormsContextContainer was not using
nsXFormsControlStub properly.

It's built for the branch, and depends on at least bug 265467.
Attachment #171741 - Flags: review?(smaug)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Blocks: 278962

Comment 2

13 years ago
Comment on attachment 171741 [details] [diff] [review]
Patch v1

Looks ok.
Attachment #171741 - Flags: review?(smaug) → review+
(Assignee)

Updated

13 years ago
Attachment #171741 - Flags: superreview?(darin)
(Assignee)

Updated

13 years ago
Attachment #171741 - Flags: superreview?(darin)
(Assignee)

Comment 3

13 years ago
Created attachment 171869 [details] [diff] [review]
Patch v1 for trunk

Updated to trunk
Attachment #171741 - Attachment is obsolete: true
Attachment #171869 - Flags: superreview?(darin)

Comment 4

13 years ago
Comment on attachment 171869 [details] [diff] [review]
Patch v1 for trunk

sr=darin
Attachment #171869 - Flags: superreview?(darin) → superreview+
(Assignee)

Comment 5

13 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.