279004 - fix link to favicon

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Anne (:annevk)]

The following piece of HTML should be removed from all pages:

 <link rel="icon" href="/images/favicon.png" type="image/png">

Now we have a favicon.ico in the root of domain
(<https://addons.update.mozilla.org/favicon.ico>, see bug 278995) this is not
needed anymore. (UAs always look in the root of the domain first.) Besides, it
links to a file that does not exist.

Comment 1

[Wolf [:wolf]]

then add that file. don't assume update will *always* be at the root of a domain
to provide a favicon.ico (FYI, that favicon isn't in the update tree anyways,
its server-side only.) The HTML should not be removed, as IIRC, that's the
perferred way to introduce a favicon. :-)

Comment 2

[alanjstr]

update HAS to be at the root of the domain.  The code forces it by using
absolute urls.  About 80, by someone's count last night.

Comment 3

[Anne (:annevk)]

(In reply to comment #1)
No, all popular browsers always request a favicon.ico at the root of the domain.
You can use HTML if it is located somewhere else although you will still get a
lot of requests for /favicon.ico. Now it is located there, nothing else is
needed anymore.

Comment 4

[Wolf [:wolf]]

and there's harm in doing both? seriously. heh.

Of course, leave it to standards to break themselves by giving a method of
adding a favicon then acting like you shouldn't use it. heh. (BTW, that line is
also following what mozilla.org itself uses. is this another case of
special-casing update to be stupid on? ;-) )

Comment 5

[Anne (:annevk)]

mozilla.org should probably have its own bug.

Anyway, we found out yesterday that the favicon that was linked from the HTML
was broken and that a file /favicon.ico existed, albeit with the wrong MIME type.

Since that was fixed there is no need for this line of HTML. It does not do harm
to have it but it can simply be omitted.

Comment 6

[Anne (:annevk)]

Attachment: patch

This fixes both this bug and bug 258478.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 171866 [details] [diff] [review]
patch

Firefox checks for the <link> version first, instead of hammering the server. 
See bug 204393 for details.

Comment 8

[Anne (:annevk)]

Attachment: patch #2

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I un-bit-rotted the patch and checked it in.

Trunk:
Checking in mozilla/webtools/update/core/inc_header.php;
/cvsroot/mozilla/webtools/update/core/inc_header.php,v  <--  inc_header.php
new revision: 1.9; previous revision: 1.8
done

Branch:
Checking in mozilla/webtools/update/core/inc_header.php;
/cvsroot/mozilla/webtools/update/core/inc_header.php,v  <--  inc_header.php
new revision: 1.6.2.2; previous revision: 1.6.2.1
done

Not resolving bug 258478 - someone who's familiar with the bug can confirm that
it is fixed.