Last Comment Bug 279034 - Add autosave option to MailNews Preferences
: Add autosave option to MailNews Preferences
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Message Display (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Stefan Borggraefe
Depends on: 16360
Blocks: 279031
  Show dependency treegraph
Reported: 2005-01-19 13:44 PST by Stefan Borggraefe
Modified: 2005-01-21 08:00 PST (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (9.13 KB, patch)
2005-01-19 15:39 PST, Stefan Borggraefe
no flags Details | Diff | Splinter Review
Screenshot of the patch in action (45.93 KB, image/png)
2005-01-19 15:41 PST, Stefan Borggraefe
no flags Details
Patch V1.1 (31.98 KB, patch)
2005-01-19 16:39 PST, Stefan Borggraefe
no flags Details | Diff | Splinter Review
Patch V1.1 (for real) (9.18 KB, patch)
2005-01-19 17:17 PST, Stefan Borggraefe
neil: review+
mozilla: superreview+
Details | Diff | Splinter Review

Description Stefan Borggraefe 2005-01-19 13:44:43 PST
Add UI for the new autosave option introduced with bug 16360. I have a patch
ready for this. I file this new bug to avoid spam too many people (bug 16360 has
72 votes).
Comment 1 Stefan Borggraefe 2005-01-19 15:39:42 PST
Created attachment 171813 [details] [diff] [review]

I also changed some other things in this pane:
  - Corrected some accesskeys ("r" was used two times, "I" was
    used for Inline).
  - Removed some very old commented-out code and an useless comment.
    I couldn't find a hint why this was commented out instead of deleted.
    It is just a copy of the XUL that is used to generate the
    Character Encoding menulist.
  - Removed the unused string languagesTitle.label.
  - Changed the forward setting from a menulist to a radiogroup.
    This way this option is less hidden and one needs less mouse-clicks
    to change it.
  - Changed "Character Encoding" to "Default Character Encoding" for
    consistency with the pref panes Navigator|Languages and
    Mail & Newsgroups|Message Display. Also the related checkbox below
    this menulist speaks about "Always use this default ...".

If this is too much unrelated stuff in this patch, please protest. ;-)
Alternatively I could file a separate bug.
Comment 2 Stefan Borggraefe 2005-01-19 15:41:49 PST
Created attachment 171814 [details]
Screenshot of the patch in action
Comment 3 2005-01-19 16:23:54 PST
Comment on attachment 171813 [details] [diff] [review]

OK, a quick glance through the patch:

>     <hbox align="center">
>+      <label value="&forwardMsg.label;"/>
>+      <radiogroup id="forwardMessageMode" orient="horizontal"
>+                  prefstring="mail.forward_message_mode">
>+        <radio value="2" label="&inline.label;" accesskey="&inline.accesskey;"/>
>+        <radio value="0" label="&asAttachment.label;" accesskey="&asAttachment.accesskey;"/>
>+      </radiogroup>
>     </hbox>
If you put the label inside the (centred) radiogroup you shouldn't need the
hbox any more.

>-<!ENTITY forwardMsg.accesskey                 "F">
You could give this key to a more deserving field.

>-<!ENTITY inline.accesskey                     "I">
>+<!ENTITY inline.accesskey                     "e">
I don't like this change but only because the Message/Forward As menu also uses

>+<!ENTITY autoSave.label                       "Automatically save the message every">
>+<!ENTITY autoSave.accesskey                   "m">
>+<!ENTITY autoSaveEnd.label                    "minutes">
This needs an l10n note.

>-<!ENTITY sendDefaultCharset.accesskey         "r">
>-<!ENTITY replyInDefaultCharset.accesskey      "r">
You don't have to remove both "r" access keys!
Comment 4 Stefan Borggraefe 2005-01-19 16:39:36 PST
Created attachment 171820 [details] [diff] [review]
Patch V1.1

Addressed Neil's initial comments.
Comment 5 Ian Neal 2005-01-19 17:16:54 PST
Wrong patch again?
Comment 6 Stefan Borggraefe 2005-01-19 17:17:47 PST
Created attachment 171825 [details] [diff] [review]
Patch V1.1 (for real)

I uploaded the wrong patch... I guess I better go to bed now. ;-)
Comment 7 Ben Bucksch (:BenB) 2005-01-20 06:57:52 PST
>   - Changed the forward setting from a menulist to a radiogroup.
>     This way this option is less hidden and one needs less mouse-clicks
>     to change it.

You think it's a good idea  to raise the prominence of this pref? I wouldn't,
for political reasons. I personally (as a recipient) much prefer the default
(attachment), because inline removes headers, forces a layout and removes the
information that it's an attached mail, which means you can't drag&drop the
forwarded mail directly into your folder (if Mailnews allowed that) etc.. Maybe
move that into another bug.

Otherwise: Thanks for the patch.
Comment 8 Ben Bucksch (:BenB) 2005-01-20 07:13:19 PST
Nevermind my last comment
Comment 9 2005-01-20 11:37:43 PST
Comment on attachment 171825 [details] [diff] [review]
Patch V1.1 (for real)

Well, the panel's a little too "busy" for my liking, but I can't obviously see
how to improve it. By the way, populateFonts() belongs in Startup().
Comment 10 Stefan Borggraefe 2005-01-20 16:28:49 PST
Fix checked in.

Note You need to log in before you can comment on or make changes to this bug.