279039 - Adding a new application in Application Manager - formkey mismatch error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Alex Sirota (iosart)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Dev.CP > Application Manager > Add New Application...
Fill the form and press 'Add Application'.
Red WARNING: FORMKEY MISMATCH! Error, application isn't added.

In appmanager.php there are only two calls to writeFormKey - when !function and
when $function=="editversion". In this case - ($function=="addnewapp") there is
no writeFormKey, thus the verification will fail.


Reproducible: Always

Comment 1

[Alex Sirota (iosart)]

Attachment: add a call to writeFormKey in "addnewapp"

My first mozilla patch. Hope I did everything right :)

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Branch:
Checking in mozilla/webtools/update/developers/appmanager.php;
/cvsroot/mozilla/webtools/update/developers/appmanager.php,v  <--  appmanager.php
new revision: 1.5.2.1; previous revision: 1.5
done

Trunk:
Checking in mozilla/webtools/update/developers/appmanager.php;
/cvsroot/mozilla/webtools/update/developers/appmanager.php,v  <--  appmanager.php
new revision: 1.6; previous revision: 1.5
done