279059 - Need to seperate out refreshing code from revalidate

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Placeholder bug.  In order to make handling of xforms-refresh and function call
to refresh to work, we need to seperate out refresh code from revalidate code
inside nsXFormsModelElement.cpp.

Comment 1

[Allan Beaufour]

(In reply to comment #0)
> Placeholder bug.  In order to make handling of xforms-refresh and function call
> to refresh to work, we need to seperate out refresh code from revalidate code
> inside nsXFormsModelElement.cpp.

Check. nsXFormsModelElement::Revalidate() just needs to save the controls
needing a refresh in a member array, so nsXFormsModelElement::Refresh() can go
through them.

Comment 2

[Allan Beaufour]

Attachment: Fix

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 173006 [details] [diff] [review]
Fix

Would it be possible for controls to be removed from the document between the
call to Revalidate and the call to Refresh()? If so, this will call through a
dangling pointer.  We either need to notice when controls are removed and
remove them from mControlsNeedingRefresh, or make it a nsCOMArray that can hold
a strong reference.

Comment 4

[aaronr]

crap, I didn't even think of that when I reviewed it.

Probably could be removed from this list during RemoveFromModelList().  Maybe
change the name to RemoveFromModelLists().

Comment 5

[aaronr]

sorry, I meant maybe it should be added to:
nsXFormsModelElement::RemoveFormControl().

Comment 6

[Allan Beaufour]

Attachment: Updated to current CVS, and fixed comment from bryner

Comment 7

[Allan Beaufour]

Check in by bryner