279078 - XML Error reporting confusing since Expat landing

Status: RESOLVED FIXED

(Core :: XML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

 Load the attached testcase (which happens to be invalid XML).

ACTUAL RESULTS:  Error message says:

  XML Parsing Error: mismatched tag. Expected: </htpp://goo/?aaa>.

EXPECTED RESULTS:  Error message that says:

  XML Parsing Error: mismatched tag. Expected: </aaa>.

or something along those lines (what it was pre-Expat landing).

It looks like we're dumping the whole string we got from expat, complete with
the U+FFFF (that's the '?' char) out in this error.  We should probably not do
that.....

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Also fixes bug 205561.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171879 [details] [diff] [review]
v1

>+        // Since this'll use |white-space: pre;| a tab equals 8 spaces.

Is that true?  What about the string

  "  \t"

?  I'd expect the tab to equal 6 spaces, then... Test?

>+     *  Expat can send the following:

Why not just use SplitExpatName here?  It'll do a bit of extra work (you'll
have to grab the strings from inside the atoms).  But this is not
perf-sensitive, and not duplicating code is worth it, I think.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1.1

(In reply to comment #2)
> (From update of attachment 171879 [details] [diff] [review] [edit])
> >+	    // Since this'll use |white-space: pre;| a tab equals 8 spaces.
> 
> Is that true?  What about the string
> 
>   "  \t"
> 
> ?  I'd expect the tab to equal 6 spaces, then... Test?

You're right, I misread the CSS spec. :-/

> Why not just use SplitExpatName here?  It'll do a bit of extra work (you'll
> have to grab the strings from inside the atoms).  But this is not
> perf-sensitive, and not duplicating code is worth it, I think.

It's not really possible until we either link the parser into layout, or we
move the error reporting into content. Both are non-trivial, so I'd like to
keep my patch for now.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171924 [details] [diff] [review]
v1.1

r+sr=bzbarsky