279084 - save dialog ignores umask when creating directories

Status: RESOLVED EXPIRED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Ben Smith]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041123 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041123 Firefox/1.0

The umask should be used in *nix to determine the file permissions of newly
created files and directories.  The firefox save dialog ignores the user's umask
when creating new directories.

Reproducible: Always

Steps to Reproduce:
1. file -> save page as -> create new directory


Actual Results:  
directory is created with 0755 permissions (rwxr-xr-x)

Expected Results:  
directory should be created with permissions determined by umask

This is a huge pain for us.  We use shared groups with group-writeable
directories and this bug means that every directory created by users in a shared
directory has restrictive permissions by default, regardless of the umask we
choose to set.

Mozilla/Thunderbird/Firefox is the only application I have yet found that
blatantly disregards umask.

Comment 1

[timeless]

is this a gtk2 filepicker or a xul filepicker?

Comment 2

[Ben Smith]

It's gtk2 but I don't think it makes a difference.

Comment 3

[Ben Smith]

I've tried changing a few instances of 0755 in the source to 0775, for instance
in filepicker.js, to no avail.  Directories are still created with 0755
permissions.  I can't seem to figure out where these permissions are coming from.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> It's gtk2 but I don't think it makes a difference.

It does, since we don't control the behavior of the GTK2 picker.

> for instance in filepicker.js

That's the XUL filepicker...

> I can't seem to figure out where these permissions are coming from.

From somewhere inside GTK2, I would bet -- I don't see any 755s in the Mozilla
GTK2 filepicker code.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I didn't think ff 1.0 used the gtk2 filepicker? consider
http://lxr.mozilla.org/aviarybranch/source/widget/src/gtk2/nsWidgetFactory.cpp#135

Ben: Are you using firefox as downloaded from mozilla or as shipped with some
distribution?

Comment 6

[Ben Smith]

I'm using FF 1.0 from Fedora (3 I think) and Mozilla 1.7.3 also from Fedora,
both of which appear (to me, from the spec files) to use the gtk2 filepicker.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yes, the RPMs shipped by Fedora use the GTK2 picker.

Comment 8

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 9

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 10

[Philip Withnall (unavailable)]

*** Bug 325334 has been marked as a duplicate of this bug. ***