Closed Bug 279135 Opened 20 years ago Closed 16 years ago

pressing "O" to highlight a bookmark starting with "O" does "Open in Tabs" instead

Categories

(Firefox :: Bookmarks & History, defect, P4)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: wagnertp, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: access, helpwanted) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Under Bookmark Toolbar Folder, I have a folder called College Sites that has a
folder called Basketball.  this fodler has approx 240 bookmarks.  When pointing
at folder basketball, the list doesn't fit on screen so I use the first letter
to reposition the list but when pressing the letter "O" it open 240 tabs at the
same time which basically hangs it since it is trying to load all the pages,
although it seems to be working.  All other letters seem to reposition the list
fine so far.

Reproducible: Always

Steps to Reproduce:
1. Click on bookmark folder
2.  point to subfolder to open it
3.  press the letter "O" to reposition the list to the first occurance of
bookmarks starting with "O"


Actual Results:  
it open 240 tabs and starts loading them

Expected Results:  
position the bookmark list to the first occurance of the letter "O"

no crash but becomes very slow trying to load 240 pages at once
Summary: pressing "O" to position bookmark list to first occurance of that letter results in opening every bookmark in a a separate tab → pressing "O" to highlight a bookmark starting with "O" does "Open in Tabs" instead

*** This bug has been marked as a duplicate of 204402 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Keywords: access
Resolution: --- → DUPLICATE
Blocks: firekey
Ever confirmed: true
Acidentally marked as duplicate.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Keywords: helpwanted
Priority: -- → P4
Is this the bookmark window or the bookmark sidebar?
The reporter was using a folder on his bookmarks toolbar.
(In reply to comment #3)
> Is this the bookmark window or the bookmark sidebar?
i have a folder called College Sites on the Bookmark Toolbar, then a subfolder
called Basketball.  this has 240 bookmarks in it.  
it looks like the Open Tabs is added automatically to each folder and since a
shortcut key has been assigned to the letter "O", it fires instead of the search
to resposition the list.

my suggested solution is to not add the Open In Tabs item to a bookmark folder
if the number of bookmarks in that folder is greater than a designated number. 
it is nice feature for a small number of bookmarks.  
This could a serious bug for computers with a low amount of memory because it
could cause a hang/freeze with so many tabs opening/loading at once.

I would suggest "Open in Tabs" to not be listed in the folder's list since it is
available by right-clicking the folder. (I personally don't find a real use for
this function anyways)

I don't know how else you could get around this otherwise.
Would just removing the access key be an acceptable workaround? "End" exists as
a quick way to go to directly to the "Open in Tabs" item.
(In reply to comment #8)
> Would just removing the access key be an acceptable workaround? "End" exists as
> a quick way to go to directly to the "Open in Tabs" item.

yes and i think it is the only fix
Hmm, really this is an issue with all menus... Alt+B and then "M" gives "Manage
Bookmarks", not the first bookmark beginning with "M" (bug 261985). Same goes
for the "Go" menu.

Should typing the first-letter even be a way to access the menus? It doesn't
have much use if accesskeys take precedence all the time, and removing all
access keys obviously isn't an option.
(In reply to comment #10)
> Hmm, really this is an issue with all menus... Alt+B and then "M" gives "Manage
> Bookmarks", not the first bookmark beginning with "M" (bug 261985). Same goes
> for the "Go" menu.
> 
> Should typing the first-letter even be a way to access the menus? It doesn't
> have much use if accesskeys take precedence all the time, and removing all
> access keys obviously isn't an option.

this has nothing to do with menus, please review the initial description. 
once a bookmark folder has been displayed, you can press a letter to position
the list to the first occurance of the letter. 
(In reply to comment #11)
> this has nothing to do with menus, please review the initial description. 
> once a bookmark folder has been displayed, you can press a letter to position
> the list to the first occurance of the letter.

This has everything to do with menus. Please review my comment. The bug is that
acesskeys (like "O" in the bookmarks toolbar menu) takes precedence over the
"first-letter selection" behavior, and that applies to more than the bookmarks
menu (like the "Go" menu, for example).

Really, this bug and bug 261985 are dupes of bug 234497, and it was WONTFIXED
for lack of a better solution.
(In reply to comment #12)
> (In reply to comment #11)
> > this has nothing to do with menus, please review the initial description. 
> > once a bookmark folder has been displayed, you can press a letter to position
> > the list to the first occurance of the letter.
> 
> This has everything to do with menus. Please review my comment. The bug is that
> acesskeys (like "O" in the bookmarks toolbar menu) takes precedence over the
> "first-letter selection" behavior, and that applies to more than the bookmarks
> menu (like the "Go" menu, for example).
> 
> Really, this bug and bug 261985 are dupes of bug 234497, and it was WONTFIXED
> for lack of a better solution.


i was wrong and agree.  i looked at those other bugs and i think the decision
makers should seperate the program menus and user created folders when making a
decision.  The only access key in user created folders is Open in tabs which
seems to be added automatically as i could find no option to exclude it.  


Similar to bug 261985


I suggest a fix where we simply remove the accesskey from "Open in Tabs", so
that O still works because it's the first letter, but also will cycle if there
are other things that begin with O.
I attached a patch for bug 261985 that resolves this bug as well!  Marking this
bug dependent on 261985.
Depends on: 261985
(In reply to comment #15)
> I attached a patch for bug 261985 that resolves this bug as well!  Marking this
> bug dependent on 261985.

Per Gavin I've removed the "fix" for this bug from my patch to bug 261985.  This
isn't an acceptable solution as it also removes the accesskey from "Open in
Tabs" when accessing the context menu of the bookmark folder menu!
No longer depends on: 261985
Assignee: vladimir+bm → nobody
Status: REOPENED → NEW
QA Contact: mconnor → bookmarks
I found the same bug (quite by surprise) when trying to launch Orbitz from my
Travel bookmarks.  Frankly, I can't see much reason why I would want to have an
Open In Tabs command in the bookmarks section.  Perhaps there are other users
who think this is a nifty way to get back to a favorite set of tabs, but for me
this 'feature' turned out to be just a minor PITA.

Two possible solutions:

1. Change behavior so that input focus toggles between {Open in Tabs} and
bookmarked items that happen to start with "O", and keep toggling until <Enter>
is pressed, instead of giving priority to {Open in Tabs}.

2. Allow people like me to get rid of the menu item via a new check box option
under Tools > Options > Advanced > Tabbed Browsing.

Looking forward to resolution of this in the next release of Firefox.  Thanks
for listening.

Jim Schibler
Software Product Manager
Dionex
*** Bug 324347 has been marked as a duplicate of this bug. ***
I will gladly vote for this.  As somebody accustomed to keyboard navigation, pressing 'O' to navigate to an 'O' bookmark is as natural as any of the other letters, yet the consequences are awful; especially with low ram in the system.  I don't really see why the 'O' shortcut is necessary, since it's not even accessible unless the menu is already selected (unlike say Ctrl+P which can be used from anywhere).  If a shortcut is needed, can't it just be converted to an Alt+ or Shift+ key combo instead?
Severity: normal → minor
Comment #19: 'O' accelerator is there for "Open in tabs" because all menu actions have access keys. (It's not a "hotkey", like Ctrl-P is. See http://www.mozilla.org/access/keyboard/ for the definition.) The issue is that these accelerators take precendence over "implicit" accelerator for the bookmarks. Bug 306010 has been opened to deal with the underlying problem and so this bug should depend on it. (If the reporter or the assignee could please set the depends field, I don't have the permissions.)
Depends on: 306010
*** Bug 353845 has been marked as a duplicate of this bug. ***
As the person who filed Bug 353845, I would point out that Open in Tabs is a destructive operation.  All existing tabs are destroyed and replaced by newly opened tabs.   A destroyed tab could contain an in-progress transaction with a significant amount of input data.  Thus the consequences of this problem can be more serious than mere annoyance.

I believe this is now resolved in the latest Minefield builds!

~B
Sure - we no longer have the "open all in tabs" menu item.
Status: NEW → RESOLVED
Closed: 20 years ago → 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.