279136 - Problem upgrading from 2.16.6 to 2.18

Status: RESOLVED WORKSFORME

(Bugzilla :: Installation & Upgrading, defect)

Description

[Mattias Andersson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

After uppgrading from 2.16.6 to 2.18 I get the error below when creating a 
new bug (and also when editing the newly created bug).

Internal Error


Bugzilla has suffered an internal error. Please save this page and send it 
to [e-mail] with details of what you were doing at the time this message 
appeared.

URL: http://ior.yyy.com/bugzilla/process_bug.cgi

undef error - Undef to trick_taint at Bugzilla/Util.pm line 51 
Bugzilla::Util::trick_taint('undef') called at Bugzilla/BugMail.pm line 166 
Bugzilla::BugMail::ProcessOneBug(2954) called at Bugzilla/BugMail.pm line 
134 Bugzilla::BugMail::Send(2954,'HASH(0x8deb0cc)') called at 
Bugzilla/Template.pm line 377 
Bugzilla::Template::__ANON__(2954,'HASH(0x8deb0cc)') called at 
data/template/template/en/default/bug/process/bugmail.html.tmpl line 24 eval 
{...} called at 
data/template/template/en/default/bug/process/bugmail.html.tmpl line 16 
Template::Provider::__ANON__('Template::Context=HASH(0x8cc9258)') called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Document.pm 
line 140 eval {...} called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Document.pm 
line 138 
Template::Document::process('Template::Document=HASH(0x8e58ebc)','Template::Context=HASH(0x8cc9258)')

called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Context.pm 
line 350 eval {...} called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Context.pm 
line 320 
Template::Context::process('Template::Context=HASH(0x8cc9258)','bug/process/bugmail.html.tmpl','HASH(0x8dc603c)')

called at data/template/template/en/default/bug/process/results.html.tmpl 
line 42 eval {...} called at 
data/template/template/en/default/bug/process/results.html.tmpl line 16 
Template::Provider::__ANON__('Template::Context=HASH(0x8cc9258)') called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Document.pm 
line 140 eval {...} called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Document.pm 
line 138 
Template::Document::process('Template::Document=HASH(0x8ddc7c8)','Template::Context=HASH(0x8cc9258)')

called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Context.pm 
line 350 eval {...} called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Context.pm 
line 320 
Template::Context::process('Template::Context=HASH(0x8cc9258)','Template::Document=HASH(0x8ddc7c8)')

called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Service.pm 
line 97 eval {...} called at 
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template/Service.pm 
line 94 
Template::Service::process('Template::Service=HASH(0x8c6f97c)','bug/process/results.html.tmpl','HASH(0x8c05b60)')

called at /usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi/Template.pm 
line 76 
Template::process('Bugzilla::Template=HASH(0x8c05c14)','bug/process/results.html.tmpl','HASH(0x8c05b60)')

called at /var/www/html/bugzilla/process_bug.cgi line 1717


Reproducible: Always




The problem is that the lastdiffed column in the bugs table had the 
wrong definition. It was datetime NULL instead of datetime NOT NULL.

The first version i installed was 2.8 many years ago ;) and the lastdiffed
column was introduced in 2.10 (with datetime NOT NULL). I have upgraded the
installation with stable releases only (from 2.8 to 2.18) and I haven't had any
problems regarding lastdiffed column before. So changes in 2.18 made this visible.

I report this bug incase someone else triggers the same error.

Comment 1

[Frédéric Buclin]

mkanat? Is that a valid bug? Any idea what the problem is?

Comment 2

[Zach Lipton [:zach]]

http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/checksetup.pl#3790
should be setting lastdiffed to NOT NULL, not NULL, right?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/checksetup.pl#3790
> should be setting lastdiffed to NOT NULL, not NULL, right?

  No, lastdiffed starts out as NULL when a bug is first filed, now. It was the
easiest solution for PostgreSQL support, which enforced the NOT NULL constraint.
In general, we've found that it's easier to have a NULL date than to have to
have some "beginning of time" date to compare against, in many circumstances.

Comment 4

[Max Kanat-Alexander]

(In reply to comment #3)
>   No, lastdiffed starts out as NULL when a bug is first filed, now.

  However, in 2.18, lastdiffed is still NOT NULL. (The LXR link above is to
2.19-only code.) 

  I have no idea how lastdiffed became NULL in your database... I just ran a
test upgrade from 2.16.6 to 2.18 on landfill (our Bugzilla testing machine) and
I see lastdiffed as NOT NULL.

  So maybe some local change on your system made this happen. I'm not sure!

Comment 5

[Max Kanat-Alexander]

Actually, technically, this should be WORKSFORME.